From 1fd4a229c8ffd02bda15c84b5a52e41e90dd463d Mon Sep 17 00:00:00 2001 From: Erich Gubler Date: Mon, 22 Apr 2024 16:44:24 -0400 Subject: [PATCH] feat(update_expected)!: recommend `disabled` on entirely `SKIP`ped tests --- moz-webgpu-cts/src/main.rs | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/moz-webgpu-cts/src/main.rs b/moz-webgpu-cts/src/main.rs index ff96e61..a1cba74 100644 --- a/moz-webgpu-cts/src/main.rs +++ b/moz-webgpu-cts/src/main.rs @@ -620,7 +620,27 @@ fn run(cli: Cli) -> ExitCode { // Do this so that test runs whose coverage _in aggregate_ includes actual // runs on this test are viable for processing. Otherwise, we'd have `SKIP` // outcomes be included that aren't actually wanted. - if *reported != skip { + if *reported == skip { + if properties.is_disabled { + // Let this outcome be processed as others. + } else { + log::warn!( + concat!( + "`{}` was the only outcome found ", + "in the set of reported test outcomes(s) ", + "for {:?} with platform {:?} and build profile {:?}, ", + "which means it wasn't run; ", + "consider marking the individual test as ", + "`disabled` ", + " to silence this warning", + ), + skip, + test_path, + platform, + build_profile, + ) + } + } else { let skip = skip.into(); if reported.inner().is_superset(skip) { log::debug!(