Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 2.0.0 ⪮ #139

Merged
merged 10 commits into from
Mar 1, 2020
Merged

Bump to 2.0.0 ⪮ #139

merged 10 commits into from
Mar 1, 2020

Conversation

erikengervall
Copy link
Owner

I feel that this library has matured into its second major release. The parts I felt uncomfortable with have been removed (e.g. the initial concept of Runners) and the library has evolved into something a lot more user-friendly.

It should be major because the interface has completely changed towards the user.

It should be bumped at this point in time because the interface has reached a stable state and there has been extensive local testing.

I welcome feedback on this decision 👐🏼

cc @n1ru4l

@n1ru4l
Copy link
Collaborator

n1ru4l commented Feb 18, 2020

Still have not tested 2.0.0-beta yet as I did not have any spare time for migrating over the log collection feature from my fork - we can still do this after the 2.0 release. Other than that everything seems to be pretty stable, sometimes the tests can be a bit flaky on CI, but I do not know whether we can fix this 100% 😕.

Feel free to cut a release 🥳

@erikengervall
Copy link
Owner Author

erikengervall commented Feb 19, 2020

Holding this back a few days while catching up on recent issues

EDIT: Picking this back up

@erikengervall
Copy link
Owner Author

FYI @n1ru4l, I won't expose createContainerIsHealthyHealthcheck in the initial 2.0.0 release since there's no examples/documentation on how to use it.

@erikengervall erikengervall merged commit 8eefbc0 into master Mar 1, 2020
@erikengervall erikengervall deleted the bump-to-2.0.0 branch March 1, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants