feat: support docker-in-docker #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
force-pushed
the
feat-docker-in-docker-support
branch
from
49c703e
to
be471fd
Compare
n1ru4l
commented
Mar 24, 2020
n1ru4l
force-pushed
the
feat-docker-in-docker-support
branch
4 times, most recently
from
f4818ed
to
688952e
Compare
The solution is based on a simple shell script that will detect whether the docker socket is mounted inside the container or not.
n1ru4l
force-pushed
the
feat-docker-in-docker-support
branch
4 times, most recently
from
358d142
to
4899ef5
Compare
n1ru4l
force-pushed
the
feat-docker-in-docker-support
branch
2 times, most recently
from
207c85f
to
a94c535
Compare
n1ru4l
force-pushed
the
feat-docker-in-docker-support
branch
from
a94c535
to
e9cc601
Compare
n1ru4l
commented
Apr 2, 2020
|
hey @erikengervall do you have plans on reviewing this any time soon? 😇 |
Hey! Yes, definitely! Thanks for calling me out - I'll take a look as soon as possible 🙂 |
|
Available in 2.0.2 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution is based on a simple shell script that will detect whether the docker socket is mounted inside the container or not.
I also added an example for docker-in-docker that uses the official docker dind image.
See https://stackoverflow.com/a/60830857/4202031 for an explanation.
Closes #159