feat: allow containers to connect to host machine/dockest inside container support #91
Conversation
…it is executed inside a container or not. This is a prerequisite for using dockest inside docker containers. see erikengervall#79
Detect whether dockest is run inside a docker container. Create network and link all runner containers to the dockest container.
Revert option of using a function for setting the host. Automatically set the host to the service name in dockest inside docker container mode.
Example that showcases dockest in docker. Works inside docker container and outside docker container.
… inside docker" and "dockest on docker host" environments.
n1ru4l
force-pushed
the
feat-host-based-on-container-id
branch
from
6d1f0a0
to
53a908d
Compare
|
@erikengervall Any idea why the build fails? everything seems to exit with 0 🤔The build does not fail on github actions or when run locally 😕 |
No idea why this would fail, especially since everything exits successfully. Hm, could there be some lingering resources that causes issues for Travis? |
|
Found the issue by looking at the most recent GitHub Actions which points out the error much more clearly and actually aborts the tests prematurely: For Travis it can be found at https://travis-ci.com/erikengervall/dockest/builds/130039439#L318. I wonder why it doesn't exit prematurely 😕 The cause anyhow seem to be related to linting around |
Co-Authored-By: Erik Engervall <erik.engervall@gmail.com>
Closes #79
Currently, the jest helpers are available via
dockest/dist/test-helper, ideally that would bedockest/test-helper. This would require an additional build step.The network name should be randomly generated (as the creation fails in case there already is a network with the given name). The alternative would be to reuse the existing network.
More information can be retrieved from #79
@erikengervall Let me know how you think bout this. 😊