Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease pre-pull request fork CI as well as github-actions based dispatch #229

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Ease pre-pull request fork CI as well as github-actions based dispatch #229

merged 1 commit into from
Aug 25, 2023

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Aug 24, 2023

Description

We allow GitHub actions pull requests to dispatch the other workflows when version updates are in order.

We also simplify the other conditions to be simply "on push".

@paulo-ferraz-oliveira
Copy link
Collaborator Author

@starbelly, don't really understand why CI isn't running. It's either basing itself on the new conditions (which are "all push", so should work) or the previous conditions (which included "pull request to main", so should work). I believe you can "trust it", and approve+merge. We can later see if it runs in master or not, and try to bugfix it, if not.

@starbelly
Copy link
Member

@paulo-ferraz-oliveira I've experienced this before :( Nothing to do with this action AFAIK. What you can do is push an empty commit to give it a jiggle as FYI.

Copy link
Member

@starbelly starbelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to trust approve this one 😄 There must be some trust in this world ❤️

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 2a21db5 into erlef:main Aug 25, 2023
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/workflow-dispatch-on-github-actions-pull-request branch August 25, 2023 16:04
@paulo-ferraz-oliveira
Copy link
Collaborator Author

There it goes, queue in master

image

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants