From 9ab122d04093027e9ff31ab42a2fdcbafe5b6642 Mon Sep 17 00:00:00 2001 From: Shunichi Shinohara Date: Tue, 21 Apr 2020 12:27:32 +0900 Subject: [PATCH 1/2] Remove quote of FOREGROUNDOPTIONS --- priv/templates/extended_bin | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/priv/templates/extended_bin b/priv/templates/extended_bin index 986249adf..7bc961699 100755 --- a/priv/templates/extended_bin +++ b/priv/templates/extended_bin @@ -844,7 +844,7 @@ case "$1" in export PROGNAME # Dump environment info for logging purposes - echo "Exec: $BINDIR/erlexec" "$FOREGROUNDOPTIONS" \ + echo "Exec: $BINDIR/erlexec" $FOREGROUNDOPTIONS \ -boot "$BOOTFILE" -mode "$CODE_LOADING_MODE" \ -boot_var SYSTEM_LIB_DIR "$SYSTEM_LIB_DIR" \ -config "$RELX_CONFIG_PATH" \ @@ -857,7 +857,8 @@ case "$1" in relx_run_hooks "$PRE_START_HOOKS" # Start the VM - exec "$BINDIR/erlexec" "$FOREGROUNDOPTIONS" \ + # The variabre FOREGROUNDOPTIONS must NOT be quoted. + exec "$BINDIR/erlexec" $FOREGROUNDOPTIONS \ -boot "$BOOTFILE" -mode "$CODE_LOADING_MODE" \ -boot_var SYSTEM_LIB_DIR "$SYSTEM_LIB_DIR" \ -config "$RELX_CONFIG_PATH" \ From dc37f490c2ff40fad05d58bea85ae3604ef8c46f Mon Sep 17 00:00:00 2001 From: Shunichi Shinohara Date: Wed, 22 Apr 2020 10:28:30 +0900 Subject: [PATCH 2/2] Add shellcheck disable comments Co-Authored-By: Tristan Sloughter --- priv/templates/extended_bin | 2 ++ 1 file changed, 2 insertions(+) diff --git a/priv/templates/extended_bin b/priv/templates/extended_bin index 7bc961699..5a9c68251 100755 --- a/priv/templates/extended_bin +++ b/priv/templates/extended_bin @@ -844,6 +844,7 @@ case "$1" in export PROGNAME # Dump environment info for logging purposes + # shellcheck disable=SC2086 echo "Exec: $BINDIR/erlexec" $FOREGROUNDOPTIONS \ -boot "$BOOTFILE" -mode "$CODE_LOADING_MODE" \ -boot_var SYSTEM_LIB_DIR "$SYSTEM_LIB_DIR" \ @@ -858,6 +859,7 @@ case "$1" in relx_run_hooks "$PRE_START_HOOKS" # Start the VM # The variabre FOREGROUNDOPTIONS must NOT be quoted. + # shellcheck disable=SC2086 exec "$BINDIR/erlexec" $FOREGROUNDOPTIONS \ -boot "$BOOTFILE" -mode "$CODE_LOADING_MODE" \ -boot_var SYSTEM_LIB_DIR "$SYSTEM_LIB_DIR" \