Improved TAB completion on client #544
Conversation
Nickname completion is now handled through fuse.js. When the completed nickname is being typed at the start of the text input, a colon is added after it by the completer. In all the other cases, just a space is added.
|
I've tried to make the completion smarter by looking at a bunch of the last messages and extracting they nicks. Those will be suggested first. #434 I'll wait for suggestions before doing any further work. |
Completion on channels with huge nicklist become slow if generation is done at every keystroke. Fix works only if hints are disabled.
stop iterating early
|
I've been using this feature since and it works. |
|
My take: this should be submitted to https://github.com/erming/tabcomplete and shout can pull in the update from there. In any case, at the bare minimum this overwriting of the library should only be done as a monkeypatch at runtime - see http://davidwalsh.name/monkey-patching. |
|
as a note, tab completion is being over-hauled in thelounge/thelounge#787 |
Fixes(?) #297
Requires fuse.js
I'm not a javascript programmer, please review with suspicion.
EDIT: I should probably make travis green first. Also, I need to add a line or two to the changelog before you merge.