Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try allowing to skip coverage comment #191

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Oct 10, 2023

Description

Allowing coverage comment step to fail so tests still pass if the comment fails and small flake fix.

Resolved Issues

How Has This Been Tested?

in progress

Related Pull Requests

@gomezzz gomezzz added bug Something isn't working tests Related to the tests labels Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

@gomezzz gomezzz requested a review from FHof October 10, 2023 09:28
@gomezzz
Copy link
Collaborator Author

gomezzz commented Oct 10, 2023

@FHof this should eliminate the errors on #185 (maybe you can merge it into your branch first to double check?)

@FHof
Copy link
Collaborator

FHof commented Oct 14, 2023

I've double checked it with my Merge Request and can confirm that github actions no longer fails. The solution with continue-on-error looks good to me since MishaKav/pytest-coverage-comment#68 is still an open issue.

@gomezzz gomezzz merged commit 1692758 into main Oct 16, 2023
3 checks passed
@gomezzz gomezzz deleted the allow-skip-of-coverage-comment branch October 16, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Related to the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing on coverage check
2 participants