Skip to content

Commit

Permalink
Code review follow-up
Browse files Browse the repository at this point in the history
  • Loading branch information
@pawlooss1
pawlooss1 committed Nov 2, 2022
1 parent ea74886 commit 41540df
Showing 1 changed file with 41 additions and 41 deletions.
82 changes: 41 additions & 41 deletions src/metrics/mongoose_metrics_mam_hooks.erl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,63 +35,63 @@

%% @doc Here will be declared which hooks should be registered when mod_mam_pm is enabled.
-spec get_mam_hooks(_) -> gen_hook:hook_list().
get_mam_hooks(Host) ->
get_mam_hooks(HostType) ->
[
{mam_set_prefs, Host, fun ?MODULE:mam_set_prefs/3, #{}, 50},
{mam_get_prefs, Host, fun ?MODULE:mam_get_prefs/3, #{}, 50},
{mam_archive_message, Host, fun ?MODULE:mam_archive_message/3, #{}, 50},
{mam_remove_archive, Host, fun ?MODULE:mam_remove_archive/3, #{}, 50},
{mam_lookup_messages, Host, fun ?MODULE:mam_lookup_messages/3, #{}, 100},
{mam_flush_messages, Host, fun ?MODULE:mam_flush_messages/3, #{}, 50}
{mam_set_prefs, HostType, fun ?MODULE:mam_set_prefs/3, #{}, 50},
{mam_get_prefs, HostType, fun ?MODULE:mam_get_prefs/3, #{}, 50},
{mam_archive_message, HostType, fun ?MODULE:mam_archive_message/3, #{}, 50},
{mam_remove_archive, HostType, fun ?MODULE:mam_remove_archive/3, #{}, 50},
{mam_lookup_messages, HostType, fun ?MODULE:mam_lookup_messages/3, #{}, 100},
{mam_flush_messages, HostType, fun ?MODULE:mam_flush_messages/3, #{}, 50}
].

%% @doc Here will be declared which hooks should be registered when mod_mam_muc is enabled.
-spec get_mam_muc_hooks(_) -> gen_hook:hook_list().
get_mam_muc_hooks(Host) ->
get_mam_muc_hooks(HostType) ->
[
{mam_muc_set_prefs, Host, fun ?MODULE:mam_muc_set_prefs/3, #{}, 50},
{mam_muc_get_prefs, Host, fun ?MODULE:mam_muc_get_prefs/3, #{}, 50},
{mam_muc_archive_message, Host, fun ?MODULE:mam_muc_archive_message/3, #{}, 50},
{mam_muc_remove_archive, Host, fun ?MODULE:mam_muc_remove_archive/3, #{}, 50},
{mam_muc_lookup_messages, Host, fun ?MODULE:mam_muc_lookup_messages/3, #{}, 100},
{mam_muc_flush_messages, Host, fun ?MODULE:mam_muc_flush_messages/3, #{}, 50}
{mam_muc_set_prefs, HostType, fun ?MODULE:mam_muc_set_prefs/3, #{}, 50},
{mam_muc_get_prefs, HostType, fun ?MODULE:mam_muc_get_prefs/3, #{}, 50},
{mam_muc_archive_message, HostType, fun ?MODULE:mam_muc_archive_message/3, #{}, 50},
{mam_muc_remove_archive, HostType, fun ?MODULE:mam_muc_remove_archive/3, #{}, 50},
{mam_muc_lookup_messages, HostType, fun ?MODULE:mam_muc_lookup_messages/3, #{}, 100},
{mam_muc_flush_messages, HostType, fun ?MODULE:mam_muc_flush_messages/3, #{}, 50}
].

-spec mam_get_prefs(Acc, Params, Extra) -> {ok, Acc} when
Acc :: any(),
Params :: map(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_get_prefs(Acc, _, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMamPrefsGets, 1),
mam_get_prefs(Acc, _, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMamPrefsGets, 1),
{ok, Acc}.

-spec mam_set_prefs(Acc, Params, Extra) -> {ok, Acc} when
Acc :: any(),
Params :: map(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_set_prefs(Acc, _, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMamPrefsSets, 1),
mam_set_prefs(Acc, _, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMamPrefsSets, 1),
{ok, Acc}.

-spec mam_remove_archive(Acc, Params, Extra) -> {ok, Acc} when
Acc :: any(),
Params :: map(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_remove_archive(Acc, _, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMamArchiveRemoved, 1),
mam_remove_archive(Acc, _, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMamArchiveRemoved, 1),
{ok, Acc}.

-spec mam_lookup_messages(Result, Params, Extra) -> {ok, Result} when
Result :: {ok | error, mod_mam:lookup_result()},
Params :: map(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_lookup_messages(Result = {ok, {_TotalCount, _Offset, MessageRows}},
#{is_simple := IsSimple}, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMamForwarded, length(MessageRows)),
mongoose_metrics:update(Host, modMamLookups, 1),
#{is_simple := IsSimple}, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMamForwarded, length(MessageRows)),
mongoose_metrics:update(HostType, modMamLookups, 1),
case IsSimple of
true ->
mongoose_metrics:update(Host, [modMamLookups, simple], 1);
mongoose_metrics:update(HostType, [modMamLookups, simple], 1);
_ ->
ok
end,
Expand All @@ -103,16 +103,16 @@ mam_lookup_messages(Result = {error, _}, _, _) ->
Acc :: any(),
Params :: mod_mam:archive_message_params(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_archive_message(Acc, _, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMamArchived, 1),
mam_archive_message(Acc, _, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMamArchived, 1),
{ok, Acc}.

-spec mam_flush_messages(Acc, Params, Extra) -> {ok, Acc} when
Acc :: any(),
Params :: #{message_count := integer()},
Extra :: #{host_type := mongooseim:host_type()}.
mam_flush_messages(Acc, #{message_count := MessageCount}, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMamFlushed, MessageCount),
mam_flush_messages(Acc, #{message_count := MessageCount}, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMamFlushed, MessageCount),
{ok, Acc}.

%% ----------------------------------------------------------------------------
Expand All @@ -122,34 +122,34 @@ mam_flush_messages(Acc, #{message_count := MessageCount}, #{host_type := Host})
Acc :: any(),
Params :: map(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_muc_get_prefs(Acc, _, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMucMamPrefsGets, 1),
mam_muc_get_prefs(Acc, _, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMucMamPrefsGets, 1),
{ok, Acc}.

-spec mam_muc_set_prefs(Acc, Params, Extra) -> {ok, Acc} when
Acc :: any(),
Params :: map(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_muc_set_prefs(Acc, _, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMucMamPrefsSets, 1),
mam_muc_set_prefs(Acc, _, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMucMamPrefsSets, 1),
{ok, Acc}.

-spec mam_muc_remove_archive(Acc, Params, Extra) -> {ok, Acc} when
Acc :: any(),
Params :: map(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_muc_remove_archive(Acc, _, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMucMamArchiveRemoved, 1),
mam_muc_remove_archive(Acc, _, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMucMamArchiveRemoved, 1),
{ok, Acc}.

-spec mam_muc_lookup_messages(Result, Params, Extra) -> {ok, Result} when
Result :: {ok | error, mod_mam:lookup_result()},
Params :: map(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_muc_lookup_messages(Result = {ok, {_TotalCount, _Offset, MessageRows}},
_, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMucMamForwarded, length(MessageRows)),
mongoose_metrics:update(Host, modMucMamLookups, 1),
_, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMucMamForwarded, length(MessageRows)),
mongoose_metrics:update(HostType, modMucMamLookups, 1),
{ok, Result};
mam_muc_lookup_messages(Result = {error, _}, _, _) ->
{ok, Result}.
Expand All @@ -158,16 +158,16 @@ mam_muc_lookup_messages(Result = {error, _}, _, _) ->
Acc :: any(),
Params :: mod_mam:archive_message_params(),
Extra :: #{host_type := mongooseim:host_type()}.
mam_muc_archive_message(Acc, _, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMucMamArchived, 1),
mam_muc_archive_message(Acc, _, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMucMamArchived, 1),
{ok, Acc}.

-spec mam_muc_flush_messages(Acc, Params, Extra) -> {ok, Acc} when
Acc :: any(),
Params :: #{message_count := integer()},
Extra :: #{host_type := mongooseim:host_type()}.
mam_muc_flush_messages(Acc, #{message_count := MessageCount}, #{host_type := Host}) ->
mongoose_metrics:update(Host, modMucMamFlushed, MessageCount),
mam_muc_flush_messages(Acc, #{message_count := MessageCount}, #{host_type := HostType}) ->
mongoose_metrics:update(HostType, modMucMamFlushed, MessageCount),
{ok, Acc}.

%%% vim: set sts=4 ts=4 sw=4 et filetype=erlang foldmarker=%%%',%%%. foldmethod=marker:

0 comments on commit 41540df

Please sign in to comment.