-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod_roster
backends rewrite
#139
Closed
mpmiszczyk
wants to merge
122
commits into
esl:master
from
mpmiszczyk:feature/mod_roster_backend_rewrite
Closed
Changes from all commits
Commits
Show all changes
122 commits
Select commit
Hold shift + click to select a range
fce2f58
Indentation fixup trough whole file.
mpmiszczyk b5ce561
Seperate behaviuor from addition module interface.
mpmiszczyk 419de9b
Plain definition of backend module.
mpmiszczyk 37cb444
Moved inicializaion of backend to new module.
mpmiszczyk 04e7afe
Type definitions copied from ejabber.
mpmiszczyk b226409
Plain move function call to backend module.
mpmiszczyk 77b1963
Removed type wrapping (by backend call) form function call.
mpmiszczyk 7dcaeba
Changed patter-match order in case statment.
mpmiszczyk c51b23a
Changed return type, to allow explicit pattern match on failing version.
mpmiszczyk 17500e3
Moved writing roster version to backend module.
mpmiszczyk 0525310
REFACTORING removed need to call function with magic-accumulator
mpmiszczyk 5d60d35
REFACTORING simplified functin logic, and their responsibility.
mpmiszczyk d68df1f
Plain move function to backend module.
mpmiszczyk 7fd3027
REFACTORING removed unnecessary delegation.
mpmiszczyk 7e48448
Typo.
mpmiszczyk e973663
Document hook handlers.
mpmiszczyk fca51ad
Update `get_version` return value and usage.
mpmiszczyk 5476a53
REFACTORING extract function
mpmiszczyk b83bae2
Moved function to backend module.
mpmiszczyk eec3bfd
Typo in function call
mpmiszczyk e4795a1
REFACTORIGN Moved function to backend module.
mpmiszczyk d557139
Changed to use already existing backend_module function.
mpmiszczyk 9f4a5fa
REFACTORING moved function to backend module.
mpmiszczyk cff19b5
REFACTORING explicite change, and "obligatory" recursive call.
mpmiszczyk 5569280
REFACTORIG variable rename and more visible recursion.
mpmiszczyk fe68136
INDENTATION
mpmiszczyk eb6b1fd
REFACTORING proper inicialization of function with accumulators.
mpmiszczyk e5e997d
REFACTORING moved function to backend module.
mpmiszczyk 166c023
REFACTORING moved logic from backend to main module.
mpmiszczyk 9f20e79
Removed code duplication from backend module.
mpmiszczyk 10b0fb8
Use new backend module.
mpmiszczyk e8be6ef
Yet another typo.
mpmiszczyk 06e66e7
REFACTORING introduce variable
mpmiszczyk efc7794
REFACTORING use backend module to write to database.
mpmiszczyk 1e10dc8
BUG call with bad function arity.
mpmiszczyk cdf5ae5
REFACTORING use backend module to read from database; introduce new
mpmiszczyk e3368d6
REFACTORING use backend module.
mpmiszczyk 547e8ca
REFACTORING use new module with new return types
mpmiszczyk 0363654
Refactor to explicit recurency.
mpmiszczyk ab2e849
REFACTORING use backend module.
mpmiszczyk e462619
REFACTORING extract methid for better readability.
mpmiszczyk 509124d
Introduce behaviour module.
mpmiszczyk e1e4c8f
INDENTATION
mpmiszczyk 0bf9e1d
FIX missing type definitions.
mpmiszczyk e0ade59
Introduce new types definitions.
mpmiszczyk 5a6b155
New spec and callback definition.
mpmiszczyk 9e4602d
New spec and callback definition.
mpmiszczyk 3d514ad
REFACTORING function rename
mpmiszczyk 6197565
BUG FIX lost variable during refactoring.
mpmiszczyk f360197
Intorudce spec and callback.
mpmiszczyk c1b599f
REFACTORING function name change
mpmiszczyk bb234e3
Introduce spec and callback.
mpmiszczyk 425d8d0
Intorudce spec and callback for all the rest of functions.
mpmiszczyk fe4796d
Added "type checking" for functions accepting specific tuples.
mpmiszczyk 90d3703
REFACTORING function name change.
mpmiszczyk 6698737
Plain introduce backed module for odbc.
mpmiszczyk 5781de2
Inicialization of backend; which in oryginal module did nothing.
mpmiszczyk f6c56a2
Implement and use `roster_version`.
mpmiszczyk c7fbc30
Use backend module.
mpmiszczyk 35c31b2
Implement and use `write_version`.
mpmiszczyk 1d804ed
Implement and use `rosters_by_us`.
mpmiszczyk 5ad7b5c
FAILING spliti function into two, to meke this module more similar to
mpmiszczyk 677844e
Implmentation of get roster functionality.
mpmiszczyk 0b9b3a1
Use backend module.
mpmiszczyk 9bce311
Implementation of remove roster.
mpmiszczyk 82fc9db
REFACTORING implementaion and use of `write_roster`
mpmiszczyk 8c209b3
Use of backend module.
mpmiszczyk dd16133
Sudo implementation of transaction.
mpmiszczyk 6440dde
Unification between two bakcend-handled modules, to make differences
mpmiszczyk 30cc9d9
REFACTORING simplifiy funciton inicializaiton and structure.
mpmiszczyk f794e2b
User backend module.
mpmiszczyk 7daf9e6
Use backend module.
mpmiszczyk 24cab10
FIX include earlier omitted gropus.
mpmiszczyk 5b870cc
Use of backend module.
mpmiszczyk 8b1a351
Use of backend module.
mpmiszczyk 2dcbcdd
Removed not longer neede variables.
mpmiszczyk 65b1374
User backend module.
mpmiszczyk e4baf83
Notes; idea for introducing back odbc optimalization.
mpmiszczyk 067ab7f
Use backend module.
mpmiszczyk 2969c06
Change to gen_backend API.
mpmiszczyk a3ba006
Update and implement bahaviour; `remove_user` implementation.
mpmiszczyk b7b012b
Use backend module.
mpmiszczyk 24ecd2a
Use backend module; and possible bug fix.
mpmiszczyk aeb179d
Use backend module.
mpmiszczyk 87b52cc
INDENTATION
mpmiszczyk 3ea05c1
Use backend module.
mpmiszczyk c4c0d60
FIX possible infinite loop.
mpmiszczyk 8612530
REFACTORING extracted function.
mpmiszczyk f41f842
Introduce recursion, and point out exit points.
mpmiszczyk b8d2686
Remove usused functions.
mpmiszczyk 4cd7b21
Unify and update `transaction` in backend module.
mpmiszczyk 30db84f
Removed hooks and logic related to web-administration.
mpmiszczyk 7b45d68
Introduce-back original odbc optymalization.
mpmiszczyk a460403
Reintroduce odbc optymalization.
mpmiszczyk cdfb752
Use optimized backend function.
mpmiszczyk 4249eab
FIX reimplement lost functionality of filtering rosters based on subs…
mpmiszczyk 60208da
Removing differances inbetween modules with roster logic.
mpmiszczyk c86452d
REFACTORING usemore verbose version of what-s going on.
mpmiszczyk 49d8c34
REAFACTORING more readable function body.
mpmiszczyk 62b19fb
Make `process_item_attrs` look the same while keeping logic intact.
mpmiszczyk 2b74345
IMPORTANT Merge branch 'master' into feature/mod_roster_backend_rewrite
mpmiszczyk f84a4a7
Whitespace cleanup.
mpmiszczyk 049219d
Typos.
mpmiszczyk 482b6dd
Change guard into pattern matching.
mpmiszczyk f24b7fc
Unify `remove_user`
mpmiszczyk 6644e28
Remove unused hook.
mpmiszczyk d341e14
Simplifie call logic.
mpmiszczyk 38e82dc
Simplify variables scope.
mpmiszczyk d77b85e
Bug Fix: changed to dirty read, since function is called outside of t…
mpmiszczyk a4d0b01
Removed `optional` attribute from roster versioning.
mpmiszczyk 2ecf9d2
Change JID to LJID.
mpmiszczyk de0821f
Change JID to LJID when creatign roster not found in backend.
mpmiszczyk 9d18b0a
Use version which allows to count database reads
mpmiszczyk 213ec6f
List to binaries, and removed whitespaces.
mpmiszczyk 645bc2c
Cleaner version, and explicite handling of possible `not_found` roste…
mpmiszczyk 71c7421
Change comment to possible future improvement.
mpmiszczyk 967b514
Log if we fail to convert database entry to roster record
mpmiszczyk fb5c185
Dynamic selecting of backend module.
mpmiszczyk 18811a7
Removed unneded file with roster logic.
mpmiszczyk 378b223
Renamed backend file to fit naming and dymanic loading convention.
mpmiszczyk a01657b
Moved backend behaviour definition to `mod_roster` module.
mpmiszczyk 17b5e1c
Use LJID where possible.
mpmiszczyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new variant is harder to read and edit because of not unified alignment.