Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR retrieve inbox (clean) #2299

Merged
merged 4 commits into from
May 12, 2019
Merged

Conversation

aleklisi
Copy link
Contributor

This PR supersedes #2282

It adds personal data retrieval from inbox.

@aleklisi aleklisi requested a review from fenek May 10, 2019 07:45
@mongoose-im
Copy link
Collaborator

6455.1 / Erlang 19.3 / small_tests / 4697a07
Reports root / small

@aleklisi aleklisi force-pushed the gdpr_retrieve_inbox-clean-2 branch from c6bea9f to e6ab420 Compare May 10, 2019 08:23
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #2299 into gdpr-retrieve-clean will increase coverage by 0.21%.
The diff coverage is 92.85%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           gdpr-retrieve-clean    #2299      +/-   ##
=======================================================
+ Coverage                78.68%   78.89%   +0.21%     
=======================================================
  Files                      334      334              
  Lines                    28963    28977      +14     
=======================================================
+ Hits                     22790    22862      +72     
+ Misses                    6173     6115      -58
Impacted Files Coverage Δ
src/inbox/mod_inbox_rdbms.erl 92.85% <ø> (ø) ⬆️
src/inbox/mod_inbox.erl 94.08% <92.85%> (-0.12%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 85.52% <0%> (-3.95%) ⬇️
src/mod_bosh.erl 92.85% <0%> (-2.15%) ⬇️
src/mod_muc_room.erl 76.62% <0%> (-0.94%) ⬇️
src/ejabberd_c2s.erl 86.87% <0%> (-0.4%) ⬇️
src/pubsub/mod_pubsub.erl 71.83% <0%> (-0.13%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 84.44% <0%> (ø) ⬆️
src/mod_roster.erl 80.09% <0%> (+0.23%) ⬆️
src/ejabberd_s2s_out.erl 56.84% <0%> (+0.45%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee2b93...b442f69. Read the comment docs.

@mongoose-im

This comment has been minimized.

@mongoose-im

This comment has been minimized.

@fenek fenek force-pushed the gdpr_retrieve_inbox-clean-2 branch from 02ceb75 to b442f69 Compare May 10, 2019 15:59
@mongoose-im
Copy link
Collaborator

mongoose-im commented May 10, 2019

6472.1 / Erlang 19.3 / small_tests / 8da2f3f
Reports root / small


6472.3 / Erlang 19.3 / mysql_redis / 8da2f3f
Reports root/ big
OK: 3094 / Failed: 0 / User-skipped: 232 / Auto-skipped: 0


6472.2 / Erlang 19.3 / internal_mnesia / 8da2f3f
Reports root/ big
OK: 1220 / Failed: 0 / User-skipped: 68 / Auto-skipped: 0


6472.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 8da2f3f
Reports root/ big
OK: 469 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0


6472.4 / Erlang 19.3 / odbc_mssql_mnesia / 8da2f3f
Reports root/ big
OK: 3109 / Failed: 1 / User-skipped: 230 / Auto-skipped: 0

mod_global_distrib_SUITE:mod_global_distrib:test_pm_with_ungraceful_reconnection_to_different_server
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"eve74.13051@localhost/res1">>,escalus_tcp,
          <0.23732.3>,
          [{event_manager,<0.23723.3>},
           {server,<<"localhost">>},
           {username,<<"eve74.13051">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.23723.3>},
            {server,<<"localhost">>},
            {username,<<"eve74.13051">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"eve74.13051">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"eve74.13051">>},
           {server,<<"localhost">>},
           {password,<<"password">>},
           {port,5222},
           {stream_management,true},
           {stream_id,<<"302C87C8F9CC4276">>}]},
        10000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,138}]},
     {mod_global_distrib_SUITE,
       '-test_pm_with_ungraceful_reconnection_to_different_server/1-fun-0-',
       4,
       [{file,"mod_global_distrib_SUITE.erl"},{line,610}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {tes...

Report log


6472.5 / Erlang 19.3 / ldap_mnesia / 8da2f3f
Reports root/ big
OK: 1183 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


6472.8 / Erlang 20.0 / pgsql_mnesia / 8da2f3f
Reports root/ big / small
OK: 3128 / Failed: 0 / User-skipped: 198 / Auto-skipped: 0


6472.9 / Erlang 21.0 / riak_mnesia / 8da2f3f
Reports root/ big / small
OK: 1455 / Failed: 0 / User-skipped: 66 / Auto-skipped: 0

@fenek fenek merged commit ec387d4 into gdpr-retrieve-clean May 12, 2019
@fenek fenek deleted the gdpr_retrieve_inbox-clean-2 branch May 12, 2019 08:10
DenysGonchar pushed a commit that referenced this pull request May 27, 2019
* Implement retrieve data from mod_inbox

* Test retrieve perosnal data from mod_inbox

* Change getting backends for mod_inbox

* Check retreive from mod_inbox when module is disabled
@fenek fenek added this to the MongooseIM 3.3.0++ milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants