-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration instructions for Riak @ MIM 3.3.0+ #2339
Conversation
6694.1 / Erlang 20.3 / small_tests / 6d06449 6694.2 / Erlang 20.3 / internal_mnesia / 6d06449 6694.3 / Erlang 20.3 / odbc_mssql_mnesia / 6d06449 6694.4 / Erlang 20.3 / ldap_mnesia / 6d06449 pubsub_SUITE:tree+basic:request_all_items_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"pubsub_tools.erl"},{line,468}]},
{pubsub_tools,receive_response,3,
[{file,"pubsub_tools.erl"},{line,458}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"pubsub_tools.erl"},{line,448}]},
{escalus_story,story,4,
[{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1062}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,994}]}]}} 6694.5 / Erlang 20.3 / elasticsearch_and_cassandra_mnesia / 6d06449 6694.8 / Erlang 21.3 / mysql_redis / 6d06449 mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,433},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> => <<"muc_publish@muc.localhost">>,
<<"message">> => <<>>,
<<"to_user_id">> => <<"alice40.884649@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-0-',3,
[{file,"mod_event_pusher_rabbit_SUITE.erl"},{line,433}]},
{escalus_story,story,4,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1562}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1080}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1012}]}]}} pubsub_SUITE:dag+collection:notify_collections_with_same_leaf_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alicE5.560621@localhost/res1">>,escalus_tcp,
<0.15471.3>,
[{event_manager,<0.15409.3>},
{server,<<"localhost">>},
{username,<<"alicE5.560621">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.15409.3>},
{server,<<"localhost">>},
{username,<<"alicE5.560621">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alicE5.560621">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE5.560621">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"8AB9CC9C33225C05">>}]},
5000],
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,138}]},
{pubsub_tools,receive_response,3,
[{file,"pubsub_tools.erl"},{line,457}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"pubsub_tools.erl"},{line,448}]},
{pubsub_SUITE,'-notify_collections_with_same_leaf_test/1-fun-0-',3,
[{file,"pubsub_SUITE.erl"},{line,1370}]},
{escalus_story,story,4,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build... 6694.7 / Erlang 21.3 / pgsql_mnesia / 6d06449 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,<<"alice79.692599@localhost">>},
{<<"to">>,<<"bob79.692599@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"H2toutgmITN4umj3guXMpQ==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"pep_SUITE.erl"},{line,300}]},
{escalus_story,story,4,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1562}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1080}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1012}]}]}} sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s{error,{{assertion_failed,assert_many,true,
[is_presence,#Fun<sm_SUITE.16.116926647>],
[{xmlel,<<"presence">>,
[{<<"from">>,
<<"alicE23.768627@localhost/escalus-default-resource">>},
{<<"to">>,
<<"alice23.768627@localhost/escalus-default-resource">>},
{<<"xml:lang">>,<<"en">>}],
[]},
{xmlel,<<"presence">>,
[{<<"from">>,
<<"alicE23.768627@localhost/escalus-default-resource">>},
{<<"to">>,
<<"alice23.768627@localhost/escalus-default-resource">>},
{<<"xml:lang">>,<<"en">>}],
[]}],
" <presence from='alicE23.768627@localhost/escalus-default-resource' to='alice23.768627@localhost/escalus-default-resource' xml:lang='en'/> <presence from='alicE23.768627@localhost/escalus-default-resource' to='alice23.768627@localhost/escalus-default-resource' xml:lang='en'/>"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{sm_SUITE,resume_session_state_stop_c2s,1,
[{file,"sm_SUITE.erl"},{line,581}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1562}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1080}]},
... sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s{error,{{assertion_failed,assert_many,true,
[is_presence,#Fun<sm_SUITE.16.116926647>],
[{xmlel,<<"presence">>,
[{<<"from">>,
<<"alicE34.36149@localhost/escalus-default-resource">>},
{<<"to">>,
<<"alice34.36149@localhost/escalus-default-resource">>},
{<<"xml:lang">>,<<"en">>}],
[]},
{xmlel,<<"presence">>,
[{<<"from">>,
<<"alicE34.36149@localhost/escalus-default-resource">>},
{<<"to">>,
<<"alice34.36149@localhost/escalus-default-resource">>},
{<<"xml:lang">>,<<"en">>}],
[]}],
" <presence from='alicE34.36149@localhost/escalus-default-resource' to='alice34.36149@localhost/escalus-default-resource' xml:lang='en'/> <presence from='alicE34.36149@localhost/escalus-default-resource' to='alice34.36149@localhost/escalus-default-resource' xml:lang='en'/>"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{sm_SUITE,resume_session_state_stop_c2s,1,
[{file,"sm_SUITE.erl"},{line,581}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1562}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1080}]},
{test_se... 6694.9 / Erlang 21.3 / riak_mnesia / 6d06449 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lack of test case for -2
error, which is rather important to verify.
Codecov Report
@@ Coverage Diff @@
## master #2339 +/- ##
========================================
+ Coverage 77.32% 78.32% +1%
========================================
Files 335 335
Lines 29260 29260
========================================
+ Hits 22625 22919 +294
+ Misses 6635 6341 -294
Continue to review full report at Codecov.
|
* `3.3.0_3.3.0plus.md` has been modified by adding migration guide for Riak @ MIM 3.3.0+ * `jid-from-mam-muc-script.md` has been modified reflect the changes made to `sender-jid-from-mam-message.escript` script * `sender-jid-from-mam-message.escript` script has been changed so that it returns `-2\n` when the given stanza is not a correct MUC message.
dc7bd6a
to
51bbcef
Compare
@fenek Language fixed, tests added (technically error code |
6697.1 / Erlang 20.3 / small_tests / 28cb95d 6697.2 / Erlang 20.3 / internal_mnesia / 28cb95d 6697.4 / Erlang 20.3 / ldap_mnesia / 28cb95d 6697.3 / Erlang 20.3 / odbc_mssql_mnesia / 28cb95d sasl_external_SUITE:use_common_name:cert_with_cn_no_xmpp_addrs_identity_correct{'EXIT',tcp_close_timeout} 6697.5 / Erlang 20.3 / elasticsearch_and_cassandra_mnesia / 28cb95d 6697.8 / Erlang 21.3 / mysql_redis / 28cb95d pubsub_SUITE:dag+collection:notify_collection_and_leaf_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alicE84.374770@localhost/res1">>,escalus_tcp,
<0.15611.3>,
[{event_manager,<0.15536.3>},
{server,<<"localhost">>},
{username,<<"alicE84.374770">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.15536.3>},
{server,<<"localhost">>},
{username,<<"alicE84.374770">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alicE84.374770">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE84.374770">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"81EFD3EF51A27738">>}]},
5000],
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,138}]},
{pubsub_tools,receive_response,3,
[{file,"pubsub_tools.erl"},{line,457}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"pubsub_tools.erl"},{line,448}]},
{pubsub_SUITE,'-notify_collection_and_leaf_test/1-fun-0-',3,
[{file,"pubsub_SUITE.erl"},{line,1317}]},
{escalus_story,story,4,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/d... 6697.7 / Erlang 21.3 / pgsql_mnesia / 28cb95d pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,<<"alice24.889482@localhost">>},
{<<"to">>,<<"bob24.889482@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"mv1b30UVAxAW30Unnyg9Kw==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"pep_SUITE.erl"},{line,300}]},
{escalus_story,story,4,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1562}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1080}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1012}]}]}} 6697.9 / Erlang 21.3 / riak_mnesia / 28cb95d 6697.3 / Erlang 20.3 / odbc_mssql_mnesia / 28cb95d |
6698.1 / Erlang 20.3 / small_tests / 954ca8a 6698.4 / Erlang 20.3 / ldap_mnesia / 954ca8a sm_SUITE:parallel:subscription_requests_are_buffered_properly{error,{{badmatch,false},
[{escalus_session,stream_management,2,
[{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,227}]},
{escalus_connection,connection_step,2,
[{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,134}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
{escalus_connection,start,2,
[{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,118}]},
{sm_SUITE,'-subscription_requests_are_buffered_properly/1-fun-3-',6,
[{file,"sm_SUITE.erl"},{line,848}]},
{escalus_story,story,4,
[{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1062}]}]}} 6698.2 / Erlang 20.3 / internal_mnesia / 954ca8a 6698.3 / Erlang 20.3 / odbc_mssql_mnesia / 954ca8a 6698.5 / Erlang 20.3 / elasticsearch_and_cassandra_mnesia / 954ca8a 6698.8 / Erlang 21.3 / mysql_redis / 954ca8a mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,433},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> => <<"muc_publish@muc.localhost">>,
<<"message">> => <<>>,
<<"to_user_id">> => <<"alice31.31895@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-0-',3,
[{file,"mod_event_pusher_rabbit_SUITE.erl"},{line,433}]},
{escalus_story,story,4,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1562}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1080}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1012}]}]}} 6698.7 / Erlang 21.3 / pgsql_mnesia / 954ca8a 6698.9 / Erlang 21.3 / riak_mnesia / 954ca8a 6698.8 / Erlang 21.3 / mysql_redis / 954ca8a pubsub_SUITE:dag+collection:notify_collection_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alicE32.597349@localhost/res1">>,escalus_tcp,
<0.15471.3>,
[{event_manager,<0.15361.3>},
{server,<<"localhost">>},
{username,<<"alicE32.597349">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.15361.3>},
{server,<<"localhost">>},
{username,<<"alicE32.597349">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alicE32.597349">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE32.597349">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"FA16970DD5E542DB">>}]},
5000],
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,138}]},
{pubsub_tools,receive_response,3,
[{file,"pubsub_tools.erl"},{line,457}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"pubsub_tools.erl"},{line,448}]},
{pubsub_SUITE,'-notify_collection_test/1-fun-0-',2,
[{file,"pubsub_SUITE.erl"},{line,1232}]},
{escalus_story,story,4,
[{file,
"/home/travis/build/esl/MongooseIM/big_tests/_build/default/li... |
3.3.0_3.3.0plus.md
has been modified by adding migrationguide for Riak @ MIM 3.3.0+
jid-from-mam-muc-script.md
has been modified reflect the changesmade to
sender-jid-from-mam-message.escript
scriptsender-jid-from-mam-message.escript
script has been changed so thatit returns
-2\n
when the given stanza is not a correct MUC message.