Service cache docs #2347

ludwikbukowski · 2019-06-25T11:09:26Z

No description provided.

fenek

Please describe relation to service_admin_extra (dependency) and how it benefits this service.

mongoose-im · 2019-06-25T11:23:06Z

6722.1 / Erlang 20.3 / small_tests / 80081a4
Reports root / small

6722.2 / Erlang 20.3 / internal_mnesia / 80081a4
Reports root/ big
OK: 1253 / Failed: 1 / User-skipped: 167 / Auto-skipped: 0

pubsub_SUITE:tree+basic:subscribe_options_test

{error,{{badmatch,{{<<"pubsub#deliver">>,<<"boolean">>,<<"false">>},
           <<"pubsub#deliver">>}},
    [{pubsub_tools,'-verify_form_values/2-fun-0-',2,
             [{file,"pubsub_tools.erl"},{line,627}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1338}]},
     {pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
             [{file,"pubsub_SUITE.erl"},{line,420}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

6722.3 / Erlang 20.3 / odbc_mssql_mnesia / 80081a4
Reports root/ big
OK: 3143 / Failed: 0 / User-skipped: 278 / Auto-skipped: 0

mongoose-im · 2019-06-25T12:01:03Z

6723.1 / Erlang 20.3 / small_tests / 6861bf0
Reports root / small

6723.2 / Erlang 20.3 / internal_mnesia / 6861bf0
Reports root/ big
OK: 1260 / Failed: 1 / User-skipped: 167 / Auto-skipped: 0

sm_SUITE:parallel:subscription_requests_are_buffered_properly

{error,{{badmatch,false},
    [{escalus_session,stream_management,2,
              [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,240}]},
     {escalus_connection,connection_step,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,154}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1263}]},
     {escalus_connection,start,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,138}]},
     {sm_SUITE,'-subscription_requests_are_buffered_properly/1-fun-3-',6,
           [{file,"sm_SUITE.erl"},{line,848}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]}]}}

Report log

6723.3 / Erlang 20.3 / odbc_mssql_mnesia / 6861bf0
Reports root/ big
OK: 3143 / Failed: 0 / User-skipped: 278 / Auto-skipped: 0

6723.4 / Erlang 20.3 / ldap_mnesia / 6861bf0
Reports root/ big
OK: 1199 / Failed: 0 / User-skipped: 206 / Auto-skipped: 0

6723.5 / Erlang 20.3 / elasticsearch_and_cassandra_mnesia / 6861bf0
Reports root/ big
OK: 532 / Failed: 0 / User-skipped: 55 / Auto-skipped: 0

6723.8 / Erlang 21.3 / mysql_redis / 6861bf0
Reports root/ big
OK: 3144 / Failed: 1 / User-skipped: 280 / Auto-skipped: 0

pubsub_SUITE:tree+hometree_specific:can_create_node_with_existing_parent_path

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alicE17.347718@localhost/res1">>,escalus_tcp,
          <0.17263.3>,
          [{event_manager,<0.17250.3>},
           {server,<<"localhost">>},
           {username,<<"alicE17.347718">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17250.3>},
            {server,<<"localhost">>},
            {username,<<"alicE17.347718">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alicE17.347718">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE17.347718">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"50D9891382634C7F">>}]},
        5000],
       [{file,
          "/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"pubsub_tools.erl"},{line,457}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"pubsub_tools.erl"},{line,448}]},
     {pubsub_SUITE,'-can_create_node_with_existing_parent_path/1-fun-0-',
       1,
       [{file,"pubsub_SUITE.erl"},{line,1767}]},
     {escalus_story,story,4,
       [{file,
          "/home/travis/build/esl/MongooseIM/...

Report log

6723.7 / Erlang 21.3 / pgsql_mnesia / 6861bf0
Reports root/ big / small
OK: 3182 / Failed: 1 / User-skipped: 246 / Auto-skipped: 0

sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s

{error,{{assertion_failed,assert_many,true,
              [is_presence,#Fun<sm_SUITE.16.116926647>],
              [{xmlel,<<"presence">>,
                  [{<<"from">>,
                  <<"alicE76.715077@localhost/escalus-default-resource">>},
                   {<<"to">>,
                  <<"alice76.715077@localhost/escalus-default-resource">>},
                   {<<"xml:lang">>,<<"en">>}],
                  []},
               {xmlel,<<"presence">>,
                  [{<<"from">>,
                  <<"alicE76.715077@localhost/escalus-default-resource">>},
                   {<<"to">>,
                  <<"alice76.715077@localhost/escalus-default-resource">>},
                   {<<"xml:lang">>,<<"en">>}],
                  []}],
              "   <presence from='alicE76.715077@localhost/escalus-default-resource' to='alice76.715077@localhost/escalus-default-resource' xml:lang='en'/>   <presence from='alicE76.715077@localhost/escalus-default-resource' to='alice76.715077@localhost/escalus-default-resource' xml:lang='en'/>"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {sm_SUITE,resume_session_state_stop_c2s,1,
           [{file,"sm_SUITE.erl"},{line,581}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1562}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1080}]},
     ...

Report log

6723.9 / Erlang 21.3 / riak_mnesia / 6861bf0
Reports root/ big / small
OK: 1489 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0

mattsaidwhat · 2019-06-25T12:03:29Z

doc/advanced-configuration/Services.md

+
+### service_cache
+
+Implementation of cache storage.


The implementation

mattsaidwhat · 2019-06-25T12:03:47Z

doc/advanced-configuration/Services.md

+### service_cache
+
+Implementation of cache storage.
+Module expose one function `lookup/2` with parameters `Key` and `Fun`.


module exposes one

codecov · 2019-06-25T12:04:51Z

Codecov Report

❗ No coverage uploaded for pull request base (master@07a2fb5). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2347   +/-   ##
=========================================
  Coverage          ?   72.59%           
=========================================
  Files             ?      335           
  Lines             ?    29287           
  Branches          ?        0           
=========================================
  Hits              ?    21262           
  Misses            ?     8025           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a2fb5...b5b03be. Read the comment docs.

mattsaidwhat · 2019-06-25T12:11:57Z

doc/advanced-configuration/Services.md

+
+Implementation of cache storage.
+Module expose one function `lookup/2` with parameters `Key` and `Fun`.
+When called and the key `Key` exists in cache, the related value is returned.


when the function is called

fenek · 2019-06-25T12:15:20Z

doc/advanced-configuration/Services.md


 ### Example configuration
 ` {service_admin_extra, [{submods, [node, accounts, sessions]}]} `
+
+Module `service_admin_extra` depens on `service_cache`(see below) as cache is efficiently used for `gdpr` submodule and GDPR compilant account removal.


depens -> depends

as the cache speeds up GDPR data retrieval and removal.?

fenek · 2019-06-25T12:18:01Z

doc/advanced-configuration/Services.md

+
+### service_cache
+
+The Implementation of cache storage.


Implementation -> implementation

mongoose-im · 2019-06-25T13:33:57Z

6728.1 / Erlang 20.3 / small_tests / 3e406bd
Reports root / small

6728.2 / Erlang 20.3 / internal_mnesia / 3e406bd
Reports root/ big
OK: 1238 / Failed: 0 / User-skipped: 167 / Auto-skipped: 0

6728.4 / Erlang 20.3 / ldap_mnesia / 3e406bd
Reports root/ big
OK: 1214 / Failed: 1 / User-skipped: 206 / Auto-skipped: 0

pubsub_SUITE:dag+basic:subscribe_unsubscribe_test

{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"pubsub_tools.erl"},{line,468}]},
     {pubsub_tools,receive_response,3,
             [{file,"pubsub_tools.erl"},{line,458}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"pubsub_tools.erl"},{line,448}]},
     {escalus_story,story,4,
            [{file,"/home/travis/build/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1546}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1062}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,994}]}]}}

Report log

6728.3 / Erlang 20.3 / odbc_mssql_mnesia / 3e406bd
Reports root/ big
OK: 3143 / Failed: 0 / User-skipped: 278 / Auto-skipped: 0

goddammit · 2019-06-25T13:39:05Z

doc/advanced-configuration/Services.md


 ### Example configuration
 ` {service_admin_extra, [{submods, [node, accounts, sessions]}]} `
+
+Module `service_admin_extra` depends on `service_cache`(see below) as the cache speeds up GDPR data retrieval and removal.


Suggested change

Module `service_admin_extra` depends on `service_cache`(see below) as the cache speeds up GDPR data retrieval and removal.

The `service_admin_extra` module depends on the`service_cache`(see below) as the cache speeds up GDPR data retrieval and removal.

goddammit · 2019-06-25T13:39:43Z

doc/advanced-configuration/Services.md

+
+### service_cache
+
+The implementation of cache storage.


Suggested change

The implementation of cache storage.

Implementation of the cache storage.

not sure which one sounds better

goddammit · 2019-06-25T13:40:01Z

doc/advanced-configuration/Services.md

+### service_cache
+
+The implementation of cache storage.
+Module exposes one function `lookup/2` with parameters `Key` and `Fun`.


Suggested change

Module exposes one function `lookup/2` with parameters `Key` and `Fun`.

The module exposes a function `lookup/2` with parameters `Key` and `Fun`.

Service cache docs[skip-ci]

5f6a043

ludwikbukowski force-pushed the service-cache-docs branch from cb13f07 to 5f6a043 Compare June 25, 2019 11:11

fenek requested changes Jun 25, 2019

View reviewed changes

ludwikbukowski requested a review from fenek June 25, 2019 11:14

add GDPR submodule to service_admin_extra submodule list[skip-ci]

f95e21b

ludwikbukowski force-pushed the service-cache-docs branch from 3072e35 to f95e21b Compare June 25, 2019 11:50

mattsaidwhat reviewed Jun 25, 2019

View reviewed changes

doc/advanced-configuration/Services.md Outdated

### service_cache

Implementation of cache storage.

Copy link

mattsaidwhat Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation

mattsaidwhat reviewed Jun 25, 2019

View reviewed changes

ludwikbukowski force-pushed the service-cache-docs branch from 1ed28f5 to b15cca3 Compare June 25, 2019 12:05

mattsaidwhat reviewed Jun 25, 2019

View reviewed changes

fenek requested changes Jun 25, 2019

View reviewed changes

ludwikbukowski force-pushed the service-cache-docs branch from b15cca3 to 2c90ca0 Compare June 25, 2019 12:26

Review fixes[skip ci]

dc342e9

ludwikbukowski force-pushed the service-cache-docs branch from 2c90ca0 to dc342e9 Compare June 25, 2019 13:04

goddammit reviewed Jun 25, 2019

View reviewed changes

More review fixes

b5b03be

fenek merged commit b33de16 into master Jun 25, 2019

fenek deleted the service-cache-docs branch June 25, 2019 14:27

fenek added this to the 3.4.0 milestone Jun 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Service cache docs #2347

Service cache docs #2347

ludwikbukowski commented Jun 25, 2019

fenek left a comment

mongoose-im commented Jun 25, 2019 •

edited

Loading

mongoose-im commented Jun 25, 2019 •

edited

Loading

mattsaidwhat Jun 25, 2019

mattsaidwhat Jun 25, 2019

codecov bot commented Jun 25, 2019 •

edited

Loading

mattsaidwhat Jun 25, 2019

fenek Jun 25, 2019

fenek Jun 25, 2019

fenek Jun 25, 2019

mongoose-im commented Jun 25, 2019 •

edited

Loading

goddammit Jun 25, 2019

goddammit Jun 25, 2019

goddammit Jun 25, 2019

	Module `service_admin_extra` depends on `service_cache`(see below) as the cache speeds up GDPR data retrieval and removal.
	The `service_admin_extra` module depends on the`service_cache`(see below) as the cache speeds up GDPR data retrieval and removal.

	The implementation of cache storage.
	Implementation of the cache storage.

	Module exposes one function `lookup/2` with parameters `Key` and `Fun`.
	The module exposes a function `lookup/2` with parameters `Key` and `Fun`.

Service cache docs #2347

Service cache docs #2347

Conversation

ludwikbukowski commented Jun 25, 2019

fenek left a comment

Choose a reason for hiding this comment

mongoose-im commented Jun 25, 2019 • edited Loading

mongoose-im commented Jun 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jun 25, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mongoose-im commented Jun 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mongoose-im commented Jun 25, 2019 •

edited

Loading

mongoose-im commented Jun 25, 2019 •

edited

Loading

codecov bot commented Jun 25, 2019 •

edited

Loading

mongoose-im commented Jun 25, 2019 •

edited

Loading