Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mod_domain_isolation #3064

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Added mod_domain_isolation #3064

merged 4 commits into from
Apr 2, 2021

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Mar 31, 2021 •
edited
Loading

This PR addresses isolation.

Proposed changes include:

  • isolation

Missing:

  • there are no tests for dynamic domains, because we can't test it yet, until one-2-one message routing are implemented.
  • The code would change a bit, once we add these use case.

@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #3064 (3ddeb4e) into multi-tenancy-phase-1 (f991ee2) will increase coverage by 0.58%.
The diff coverage is 89.91%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           multi-tenancy-phase-1    #3064      +/-   ##
=========================================================
+ Coverage                  78.09%   78.68%   +0.58%     
=========================================================
  Files                        374      387      +13     
  Lines                      31219    31637     +418     
=========================================================
+ Hits                       24382    24892     +510     
+ Misses                      6837     6745      -92
Impacted Files Coverage Δ
src/admin_extra/service_admin_extra.erl 100.00% <ø> (ø)
src/auth/ejabberd_auth_anonymous.erl 48.75% <0.00%> (-1.25%) ⬇️
src/ejabberd_gen_sm.erl 90.90% <ø> (ø)
src/ejabberd_local.erl 62.68% <0.00%> (-1.50%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 89.47% <ø> (+4.47%) ⬆️
src/offline/mod_offline_mnesia.erl 51.47% <0.00%> (ø)
src/pubsub/pubsub_form_utils.erl 56.60% <0.00%> (+1.04%) ⬆️
src/rdbms/rdbms_queries_mssql.erl 100.00% <ø> (ø)
src/rdbms/mongoose_rdbms_odbc.erl 75.78% <45.45%> (-1.86%) ⬇️
src/mam/mod_mam_rdbms_arch.erl 48.45% <47.14%> (+9.18%) ⬆️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ad312...3ddeb4e. Read the comment docs.

@NelsonVides
Copy link
Collaborator

Code coverage, pleaaaase. Also, don't use ifs in erlang, they're horrible af. Use case of 🙏🏽

NelsonVides
NelsonVides reviewed Mar 31, 2021
View reviewed changes
doc/modules/mod_domain_isolation.md Show resolved Hide resolved
src/mod_domain_isolation.erl Outdated Show resolved Hide resolved
src/mod_domain_isolation.erl Outdated Show resolved Hide resolved
NelsonVides
NelsonVides approved these changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NelsonVides NelsonVides merged commit d7f064a into multi-tenancy-phase-1 Apr 2, 2021
@NelsonVides NelsonVides deleted the mu-mod_domain_isolation branch April 2, 2021 11:12
@arcusfelis arcusfelis restored the mu-mod_domain_isolation branch April 2, 2021 12:11
@arcusfelis arcusfelis mentioned this pull request Apr 2, 2021
Merged
@arcusfelis arcusfelis deleted the mu-mod_domain_isolation branch April 2, 2021 12:27
@arcusfelis
Copy link
Contributor Author

replaced with #3070

NelsonVides added a commit that referenced this pull request Apr 2, 2021
@NelsonVides
Merge pull request #3070 from esl/mu-mod_domain_isolation-to-master
8b30cbb 
Host isolation
it's a variant of #3064 but to master.
Proposed changes include:
    there is no code or solution for multi-tenancy.
    the code would probably change, once we add dynamic domains.
    could be merged to master, but multi-tenancy would have to be rebased on master to continue work on this feature. Routing would also have to be working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonVides NelsonVides NelsonVides approved these changes

Assignees
No one assigned
Labels
waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcusfelis @NelsonVides