Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfold global options without the temporary functions #3406

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Unfold global options without the temporary functions #3406

merged 4 commits into from
Nov 18, 2021

Commits on Nov 18, 2021

  1. Remove temporary functions used to unfold global options 

    These functions made it difficult to rework the resulting
internal config structure and test the expected parsed config.

Now the unfolding is explicit.
In the future we might want to get rid of unfolding
and just use {Key, global}.
However, this might mean one extra lookup for each option.
    @chrzaszcz
    chrzaszcz committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    c4e6730 View commit details
    Browse the repository at this point in the history

  2. Accept {Key, global} as config key 

    This is needed by the config parser before key unfolding.
I decided not to complicate types by introducing an extra type here
for the unfolded keys.
    @chrzaszcz
    chrzaszcz committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    c1a26af View commit details
    Browse the repository at this point in the history

  3. Update tests after reworking global option unfolding 

    Now the tests are just checking for {Key, global} and {Key, <<"myhost">>}.
    @chrzaszcz
    chrzaszcz committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    35aeb3d View commit details
    Browse the repository at this point in the history

  4. Use the host test macros for shaper, acl, access

    @chrzaszcz
    chrzaszcz committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    cd88a63 View commit details
    Browse the repository at this point in the history