Simplify the jid data structure #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
tuning_code
branch
from
f4429a1
to
bfcaf6c
Compare
NelsonVides
force-pushed
the
reduce_jid_struct
branch
from
ca516f7
to
c2601df
Compare
NelsonVides
force-pushed
the
tuning_code
branch
2 times, most recently
from
ea6fd0e
to
932a517
Compare
NelsonVides
force-pushed
the
reduce_jid_struct
branch
from
c2601df
to
7549a42
Compare
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 86.23% 85.08% -1.16%
==========================================
Files 2 2
Lines 109 114 +5
Branches 7 7
==========================================
+ Hits 94 97 +3
- Misses 15 17 +2
Continue to review full report at Codecov.
|
Remove fields that should actually never be used. The idea is that the non-normalised parts MUST actually have never been used for comparison, and are therefore not really needed. If only for printing and using them in the `to` and `from` attributes of a stanza, clients SHOULD also stringprep anyway, so the fact that the server might provide non-normalised strings might be a problem for clients who're not enforced to normalise them. I've also been verifying how many other XMPP implementations tackle this issue, and I've seen many other servers, and also a bunch of client frameworks, simply capturing the parts and normalising them, and building data structures that keep only their normalised pieces.
NelsonVides
force-pushed
the
reduce_jid_struct
branch
from
7549a42
to
a2b09d3
Compare
NelsonVides
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove fields that should actually never be used. The idea is that the
non-normalised parts MUST actually have never been used for comparison,
and are therefore not really needed. If only for printing and using them
in the
toandfromattributes of a stanza, clients SHOULD alsostringprep anyway, so the fact that the server might provide
non-normalised strings might be a problem for clients who're not
enforced to normalise them.
I've also been verifying how many other XMPP implementations tackle this
issue, and I've seen many other servers, and also a bunch of client
frameworks, simply capturing the parts and normalising them, and
building data structures that keep only their normalised pieces.
Note, I imagine this to make for a version 2.0, as it contains kinda breaking changes. Libraries shouldn't be looking into the data structure and should use the data setters and getters exposed by the API, but well, everywhere there's pattern-matching against the jid record.
Also interesting, using uuids for all three parts of the jid: