Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change member's base docker image #56

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Change member's base docker image #56

merged 1 commit into from
Sep 12, 2024

Conversation

jacekwegr
Copy link
Contributor

This PR updates the member's base Docker image from phusion/baseimage:jammy-1.0.4 to ubuntu:oracular. The new image is smaller in size and, for now, has no detected vulnerabilities.

@jacekwegr jacekwegr marked this pull request as ready for review September 10, 2024 12:26
JanuszJakubiec
JanuszJakubiec approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the report in a task, I am also sure, the Ubuntu image is currently the best solution. In the future, we can think about alpine or Debian.
Nevertheless, current image size improvement is amazing!

chrzaszcz
chrzaszcz approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and promising 👍 I think that we should create a PR to MongooseIM and run all tests though, followed by load tests. Then we can merge.

@chrzaszcz chrzaszcz merged commit cde3352 into master Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszJakubiec JanuszJakubiec JanuszJakubiec approved these changes

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacekwegr @chrzaszcz @JanuszJakubiec