-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(js): migrate quote-props to ts #137
Conversation
✅ Deploy Preview for eslint-stylistic ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 191 191
Lines 61599 61611 +12
Branches 4843 4833 -10
=======================================
+ Hits 61197 61209 +12
Misses 397 397
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Aha, it's a type issue of the |
What issue you are referring to? |
You can change the |
Great, I was think about it before, but I'm not sure these two are the same or different. |
* refactor(js): migrate quote-props to ts * fix: test case
Part of #70