Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js): migrate quote-props to ts #137

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

alexzhang1030
Copy link
Contributor

Part of #70

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for eslint-stylistic ready!

Name Link
🔨 Latest commit d934cc5
🔍 Latest deploy log https://app.netlify.com/sites/eslint-stylistic/deploys/6555e83fb18f1f00092a86cb
😎 Deploy Preview https://deploy-preview-137--eslint-stylistic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6dcd28) 99.34% compared to head (d934cc5) 99.34%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files         191      191           
  Lines       61599    61611   +12     
  Branches     4843     4833   -10     
=======================================
+ Hits        61197    61209   +12     
  Misses        397      397           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexzhang1030
Copy link
Contributor Author

alexzhang1030 commented Nov 16, 2023

Aha, it's a type issue of the @types/eslint library. Should we set up a type patch? /cc @antfu

@antfu
Copy link
Member

antfu commented Nov 16, 2023

What issue you are referring to?

@alexzhang1030
Copy link
Contributor Author

It's about the type check.

image

The imported type ValidTestCase from @types/eslint does not satisfy the test case, type check failed.

@antfu
Copy link
Member

antfu commented Nov 16, 2023

You can change the env to parserOptions: { ecmaVersion: 6 }

@alexzhang1030
Copy link
Contributor Author

You can change the env to parserOptions: { ecmaVersion: 6 }

Great, I was think about it before, but I'm not sure these two are the same or different.

@antfu antfu added this pull request to the merge queue Nov 16, 2023
Merged via the queue into eslint-stylistic:main with commit e3023a1 Nov 16, 2023
13 checks passed
antfu pushed a commit that referenced this pull request Nov 17, 2023
* refactor(js): migrate quote-props to ts

* fix: test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants