Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(padding-line-between-statements): recognize ExportAllDeclaration nodes #257

Merged
merged 3 commits into from
Jan 8, 2024
Merged

fix(padding-line-between-statements): recognize ExportAllDeclaration nodes #257

merged 3 commits into from
Jan 8, 2024

Conversation

fasttime
Copy link
Contributor

@fasttime fasttime commented Jan 6, 2024

Description

This PR adds ExportAllDeclaration to the list of export node types handled by the padding-line-between-statements rule. This change effectively aligns the eslint-plugin-ts implementation with the (already consistent) implementation of the rule in eslint-plugin-js.

An example of code affected by this change:

/*
  eslint @stylistic/ts/padding-line-between-statements: [
  "error",
  { blankLine: 'never', prev: 'export', next: 'export' }]
*/

export * from "foo";

export * as bar from "bar";

This will start to produce an error once the change is applied, like @stylistic/js/padding-line-between-statements already does.

Linked Issues

Additional context

Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for eslint-stylistic ready!

Name Link
🔨 Latest commit 2ba7d80
🔍 Latest deploy log https://app.netlify.com/sites/eslint-stylistic/deploys/659bd2b1942498000839d98f
😎 Deploy Preview https://deploy-preview-257--eslint-stylistic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fasttime fasttime marked this pull request as ready for review January 6, 2024 21:14
@antfu antfu enabled auto-merge January 8, 2024 10:46
@antfu antfu added this pull request to the merge queue Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59070ae) 99.79% compared to head (2ba7d80) 99.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         113      113           
  Lines       26500    26501    +1     
  Branches     4452     4452           
=======================================
+ Hits        26446    26447    +1     
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into eslint-stylistic:main with commit 52f0506 Jan 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants