refactor: use precomputed status data in baseline generator #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This change fixes the failing
Update baselineworkflow. The failure was caused by recent renames in@mdn/browser-compat-data@7.1.16(see mdn/browser-compat-data#28278). Our generator previously usedcompute-baseline’sgetStatusto queryBCDfor each compat key fromweb-features. Becauseweb-featuresstill referenced the old keys,compute-baselineattempted to traverse keys that had been renamed inBCD, causing errors like:To resolve this, I switched to the precomputed baseline statuses that now ship with
web-features@3.6.0, specificallystatus.by_compat_key. This removes the need to queryBCDat build time, prevents failures from key renames, and avoids version skew betweenweb-featuresandBCD.What changes did you make? (Give an overview)
compute-baselineusage.extractCSSFeatures(), replacedgetStatus(featureId, key)with precomputed statuses fromweb-features:feature.status.by_compat_key[key].Related Issues
Is there anything you'd like reviewers to focus on?