Skip to content

Conversation

@Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Oct 27, 2025

Prerequisites checklist

What is the purpose of this pull request?

This change fixes the failing Update baseline workflow. The failure was caused by recent renames in @mdn/browser-compat-data@7.1.16 (see mdn/browser-compat-data#28278). Our generator previously used compute-baseline’s getStatus to query BCD for each compat key from web-features. Because web-features still referenced the old keys, compute-baseline attempted to traverse keys that had been renamed in BCD, causing errors like:

Error: css.properties.position-area.span-x-self-end is unindexable at 'span-x-self-end'.

To resolve this, I switched to the precomputed baseline statuses that now ship with web-features@3.6.0, specifically status.by_compat_key. This removes the need to query BCD at build time, prevents failures from key renames, and avoids version skew between web-features and BCD.

What changes did you make? (Give an overview)

  • Removed compute-baseline usage.
  • In extractCSSFeatures(), replaced getStatus(featureId, key) with precomputed statuses from web-features: feature.status.by_compat_key[key].

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 27, 2025
@fasttime fasttime moved this from Needs Triage to Triaging in Triage Oct 27, 2025
@fasttime fasttime moved this from Triaging to Implementing in Triage Oct 27, 2025
@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 27, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I verified that the updated script runs locally with the latest versions of mdn-data and web-features.

@fasttime fasttime merged commit 69a76b1 into main Oct 27, 2025
23 checks passed
@fasttime fasttime deleted the baseline-precomputed-status branch October 27, 2025 13:18
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Oct 27, 2025
@rviscomi
Copy link
Contributor

rviscomi commented Oct 27, 2025

Ah we just shipped by_compat_key last week and I was planning to reach out to suggest migrating over to it. Glad to see you found it and it's already proving useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants