-
-
Notifications
You must be signed in to change notification settings - Fork 5
fix: Allow nested at-rules to have nested rules #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 17156414002Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables nested CSS rules within at-rules by propagating the allowNestedRules configuration option through the parsing chain. The fix addresses issue #66 where nested rules inside at-rules like @media were not being properly supported.
- Propagate
allowNestedRulessetting from Block to Atrule parsing - Update
@mediaat-rule handler to accept and pass through the nesting configuration - Add comprehensive test coverage for nested at-rules with nesting selectors
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/syntax/node/Block.js | Pass allowNestedRules option to Atrule parser |
| lib/syntax/node/Atrule.js | Accept and propagate allowNestedRules to block parsing |
| lib/syntax/atrule/media.js | Update media at-rule to handle allowNestedRules option |
| lib/__tests/parse.js | Add blank line (formatting change) |
| fixtures/ast/rule/nesting.json | Add test case for nested @media with nesting selector |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fasttime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request?
Allow nested at-rules to contain nested rules
What changes did you make? (Give an overview)
allowNestedRulessetting into at-rules so they can pass that on to theirBlock()calls.Related Issues
fixes #66
Is there anything you'd like reviewers to focus on?