fix: use flat config when eslintrc config does not exist #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
fix/flat-config-fallback
branch
from
3f6f106 to
252109a
Compare
Member
|
Please update the description of this PR with a description of the problem this is meant to fix, just like you would with a bug report. |
1 task
Member
Author
|
filed the issue in #290. |
nzakas
reviewed
Oct 9, 2025
|
|
||
| throw new TypeError( | ||
| `Plugin config "${configName}" in plugin "${userPluginNamespace}" is an eslintrc config and cannot be used in this context.`, | ||
| // If it's a legacy config, or the config does not exsist => look for the flat version |
Member
There was a problem hiding this comment.
Suggested change
| // If it's a legacy config, or the config does not exsist => look for the flat version | |
| // If it's a legacy config, or the config does not exist => look for the flat version |
Comment on lines
282
to
292
| // If we get here, then the config was either not found or is a legacy config | ||
| const message = directConfig | ||
| ? `Plugin config "${configName}" in plugin "${userPluginNamespace}" is an eslintrc config and cannot be used in this context.` | ||
| : `Plugin config "${configName}" not found in plugin "${userPluginNamespace}".`; | ||
| throw new TypeError(message); |
Member
There was a problem hiding this comment.
This logic doesn't seem correct to me. There could be a flatConfig that is an eslintrc, but it looks like this logic will say the config wasn't found.
aladdin-add
force-pushed
the
fix/flat-config-fallback
branch
from
71e013b to
e9c4a45
Compare
Member
|
Going to close-reopen to run CI tests with da3838f included. |
aladdin-add
force-pushed
the
fix/flat-config-fallback
branch
from
e9c4a45 to
87a2e09
Compare
aladdin-add
force-pushed
the
fix/flat-config-fallback
branch
from
87a2e09 to
fb0344c
Compare
mdjermanovic
approved these changes
Oct 13, 2025
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas to verify.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
The plugin configuration lookup logic has been refactored to better accommodate scenarios where the eslintrc does not exist.
Related Issues
fixes #290.
refs: eslint/generator-eslint#227
Is there anything you'd like reviewers to focus on?