-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add espflash troubleshooting page and 26MHz crystal issue #129
Conversation
They may need to build a bootloader anyway using an esp-idf C or Rust project. We could think about including an Regarding moving troubleshooting to a section, we had it like this in the past, but our colleague from documentation team @f-hollow recommended us to avoid that. |
Unfortunately it's not possible to nest appendix pages in mdbook and I couldn't find an alternative solution other than moving it back. |
Is there some documentation somewhere which states the guidelines being suggested? This is not the first time I've seen a suggestion that frankly makes no sense to me, so I'd like to better understand where this is coming from. |
Not that I know of, maybe Kirill does have some documentation about this. IIRC, the point was that troubleshooting is usually a kitchen sink with various "random" stuff on it, the equivalent of the utilities modules in code, and it would be better to include the information in the relevant chapter with more context where we can help the user avoid the error instead. That was the reason, again, IIRC, for keeping the troubleshooting as a small appendix not very related to the book IMHO, FAQ/Troubleshooting are useful, and we can have it as a section since many people won't read documentation, so you can just share a link and dont need to repeat yourself many times. |
93710f0
to
c4aa9d8
Compare
We always build the bootloader in esp-idf-sys - but by default not using it. Though if you are a user of |
86a6fce
to
ac69a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the PR is ready for review, but here are a few nitpicks comments, other than that, it LGTM!
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
Now it is :) thanks for the suggestions! |
Sorry, I am bit late for the party! @SergioGasquez conveyed the reason very well. From what I remember, the Troubleshooting section was a collection of unrelated topics detached from the context and without any references. Usually, it means that the users are quite unlikely to discover such information when they need it. This is why, for example, tech writers try to avoid FAQs these days for exactly the same reasons. As a tech writer, I usually do the following:
So I proposed to move Troubleshooting to Appendix as a temporary measure before you find ways to properly integrate this information with the rest of the book. Regarding the placement of Troubleshooting in general, it can be anywhere as long as the flow of the book is not affected and the information is discoverable. Basically, these guidelines are applicable to any information, not just Troubleshooting, so I am not sure if I can point to any established guidelines about where to place Troubleshooting. @jessebraham @SergioGasquez As I am not a software engineer, I might be missing some important points here. If you see any flaws in my logic, I will be glad to hear your arguments. Thank you! |
Relevant issue in espflash: esp-rs/espflash#410
I think the issue may warrant its entry in the list of troubleshooting tips.
I'm honestly not sure what the solution is for esp-hal based projects - they don't build a bootloader.