Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #169

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Fix broken link #169

merged 3 commits into from
Oct 30, 2024

Conversation

cmsong-shina
Copy link
Contributor

@cmsong-shina cmsong-shina commented Oct 29, 2024

https://github.com/esp-rs/esp-wifi#current-support is broken.
Maybe the table was moved to https://github.com/esp-rs/esp-hal/tree/main/esp-wifi#current-support?

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for disturbing again, just noticed that esp-alloc and esp-println from the table in the bottom are also pointing to the old repo: https://github.com/esp-rs/book/pull/169/files#diff-0a3ec6fd8e59bac65ee16aeab5e541fe336669f883458990909a8f105a94d614R58-R59.

Again, happy to merge as it is and I create another PR

Thanks!

Fix link of esp-alloc and esp-println.
@cmsong-shina
Copy link
Contributor Author

Ah, my bad. I reviewed all the links in the document, how did I miss the 'repository moved' notice?

cmsong-shina added a commit to cmsong-shina/rust-on-esp-book-ko-kr that referenced this pull request Oct 30, 2024
다음 수정 사항 반영
  esp-rs/book#169
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@SergioGasquez SergioGasquez merged commit d360fa5 into esp-rs:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants