Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: address #[allow()] attributes and TODO/FIXME comments #1166

Closed
jessebraham opened this issue Feb 13, 2024 · 0 comments
Closed

Housekeeping: address #[allow()] attributes and TODO/FIXME comments #1166

jessebraham opened this issue Feb 13, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed status:long-term This task will be around a while

Comments

@jessebraham
Copy link
Member

jessebraham commented Feb 13, 2024 •
edited
Loading

There are a number of places within the code base where we've added #[allow()] attributes for various reasons. In many cases, such as for clippy lints, these can probably be removed by reworking the code a bit.

Additionally, we have accumulated some // TODO and // FIXME comments, which should also be addressed.

Related work:
@jessebraham jessebraham added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 13, 2024
@jessebraham jessebraham mentioned this issue Feb 13, 2024
Merged
@jessebraham jessebraham added the status:needs-attention This should be prioritized label Apr 3, 2024
@jessebraham jessebraham added status:long-term This task will be around a while and removed status:needs-attention This should be prioritized labels May 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed status:long-term This task will be around a while
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessebraham