Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parl_io: support for optional pins #1515

Closed
CodingSamS opened this issue Apr 26, 2024 · 6 comments
Closed

parl_io: support for optional pins #1515

CodingSamS opened this issue Apr 26, 2024 · 6 comments
Labels
peripheral:parl_io PARL_IO peripheral

Comments

@CodingSamS
Copy link

I'm using an esp32c6 with dma and parl_io. I need to control 12 bits in my project. Therefore, I used esp_hal::parl_io::RxSixteenBits. Since 16 pins are required, I added 4 unused pins.

However, espressif allows -1 as value for (unused) data pins:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32c6/api-reference/peripherals/parlio.html#_CPPv423parlio_tx_unit_config_t

This would be an improvement in order to save the number of pins required.

A good solution to support this might be the usage of Option.

Briefly discussed this with @bjoernQ already.

@CodingSamS CodingSamS changed the title parl_io support for optional pins parl_io: support for optional pins Apr 26, 2024
@Dominaezzz
Copy link
Collaborator

I've been thinking about this myself (but for LCD_CAM) and it'd be nice if the GPIO Matrix was exposed to users somehow. Like allow a pin to be an input to multiple peripherals and allow configuring a 1 or 0 to the peripherals input.

Though for this issue, just having optional will do. They question is the PARL_IO will technically still be reading from these unset signals so you'll have to mask/adjust the data, or make it predictable (1 or 0).

@CodingSamS
Copy link
Author

This is the behaviour i would expect. You still need to fill the buffer for all Optionals, all of the bits will be read, but only some of them will be applied (since you can't change the state of a None pin).

Otherwise there would be some real strange cases e.g. when having 7 Pins but an 8 bit buffer.

@bjoernQ
Copy link
Contributor

bjoernQ commented Apr 27, 2024

Like allow a pin to be an input to multiple peripherals and allow configuring a 1 or 0 to the peripherals input.

Slightly off-topic but some time ago I experimented with something: bjoernQ#1

@Dominaezzz
Copy link
Collaborator

Like allow a pin to be an input to multiple peripherals and allow configuring a 1 or 0 to the peripherals input.

Slightly off-topic but some time ago I experimented with something: bjoernQ#1

Woah! That's exactly what I had in mind. I definitely have a use case for VirtualInputPin where I need to toggle the state in an interrupt. I'll open a separate issue for this!

@Dominaezzz
Copy link
Collaborator

Was this closed by #1769 ?

@MabezDev
Copy link
Member

Yep! Thanks!

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peripheral:parl_io PARL_IO peripheral
Projects
Archived in project
Development

No branches or pull requests

5 participants