Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue to reduce boilerplate #2010

Closed
bugadani opened this issue Aug 27, 2024 · 5 comments · May be fixed by #2545
Closed

Tracking issue to reduce boilerplate #2010

bugadani opened this issue Aug 27, 2024 · 5 comments · May be fixed by #2545
Assignees
Labels
api RFC Request for comment
Milestone

Comments

@bugadani
Copy link
Contributor

bugadani commented Aug 27, 2024

The goal of this issue is to lower the amount of code the users need to write for no good reason.

Feel free to share your pain point if you have any!

@esp-rs esp-rs deleted a comment Aug 27, 2024
@MabezDev MabezDev added this to the 0.21.0 milestone Aug 27, 2024
@MabezDev MabezDev added the RFC Request for comment label Aug 27, 2024
@esp-rs esp-rs deleted a comment Aug 27, 2024
@scottdalgliesh
Copy link

Would it make sense to also initialize and return the io driver by default in esp_hal::init? It seems like most use cases will require access to io, but I could certainly be overlooking/misunderstanding something.

Regardless, great work on these simplifications - love to see it.

@bugadani
Copy link
Contributor Author

bugadani commented Aug 29, 2024

^ a good thing to keep in mind, although we deliberately don't initialize any peripherals at this point.

@MabezDev
Copy link
Member

I think we should think about closing this.

It's been great to track the "obviously" good choices (the init changes etc), but I think at this point most of the decisions we need to make going forward are non-trivial and require discussion before we commit to the design. We should track those in individual issues.

@bugadani
Copy link
Contributor Author

I suppose I'll mark the last DMA PR to close this :)

@MabezDev
Copy link
Member

I think with #2532 and #2321 we can now close this. Looking back at the list it's quite amazing how much boiler plate we managed to remove in a short timer period! 🚀

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api RFC Request for comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants