Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime ISR binding for TWAI #1384

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Apr 3, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Use runtime ISR binding for TWAI

Testing

Run the adapted examples

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@jessebraham
Copy link
Member

jessebraham commented Apr 3, 2024

Hmm that's weird, let's try this again..?

EDIT: This makes no sense at all, I'm guessing, as usual, problems with GHA? I will try again in a bit, hopefully they can sort this out sooner than later.

@jessebraham jessebraham added this pull request to the merge queue Apr 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2024
@bjoernQ bjoernQ added this pull request to the merge queue Apr 3, 2024
Merged via the queue into esp-rs:main with commit ba73154 Apr 3, 2024
21 checks passed
@bjoernQ bjoernQ deleted the twai-isr-runtime-binding branch November 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants