Runtime ISR binding and simple public API docs for assist-debug #1395
Conversation
There was a problem hiding this comment.
Thanks, this all LGTM from a code perspective!
I have a question about adding a MODE param to a driver that would (correct me if I'm wrong) never have an async version. If a driver won't ever support async, then the mode param seems redundant. We could just drop the parameter here, and assume that it's always in "blocking" mode. 🤔
Good question! Would debug_assist ever make sense to be async? I think technically we could do that but will we do that? 🤔 |
|
I somehow thought GitHub lets me comment on non-changed lines but either it doesn't, it doesn't work or I don't know how. Anyways .... The example shouldn't use |
That's really good question! I think adding async doesn't make too much sense .. so if we all agree on not having async version, I'm happy to remove the |
|
If there is currently no async support, I do not think we should speculate about the possibility of it at some unknown point in the future. If the mode is not necessary then IMO it should not be a generic parameter, if we ever (for whatever reason) add async support here it's easy enough to change it at that time. |
JurajSadel
force-pushed
the
debug-assist-isr-binding
branch
from
4ceb931 to
8cd2843
Compare
|
I reverted |
JurajSadel
force-pushed
the
debug-assist-isr-binding
branch
from
8cd2843 to
1a3cddd
Compare
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Use runtime ISR binding for assist_debug and adds docs for public API.
Testing
Run modified debug_assist example.