Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AES HIL tests #1423

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Improve AES HIL tests #1423

merged 1 commit into from
Apr 11, 2024

Conversation

SergioGasquez
Copy link
Member

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Cover all the AES modes in the HIL test.

Testing

Tested locally on S2 (required to use some changes of #1412) and C6.

ESP32-S2 Output
     Running tests/aes.rs (target/xtensa-esp32s2-none-elf/debug/deps/aes-42356b01d01b75bf)
      Erasing ✔ [00:00:00] [#######################################################################] 192.00 KiB/192.00 KiB @ 209.95 KiB/s (eta 0s )
  Programming ✔ [00:00:01] [##########################################################################] 46.65 KiB/46.65 KiB @ 34.01 KiB/s (eta 0s )    Finished in 2.354s

running 6 tests
test tests::test_aes_128_encryption ... ok
test tests::test_aes_128_decryption ... ok
test tests::test_aes_192_encryption ... ok
test tests::test_aes_192_decryption ... ok
test tests::test_aes_256_encryption ... ok
test tests::test_aes_256_decryption ... ok

test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.77s
ESP32-C6 Output
     Running tests/aes.rs (target/riscv32imac-unknown-none-elf/debug/deps/aes-dc94f37583cbbc3f)
      Erasing ✔ [00:00:00] [###########################################################################] 192.00 KiB/192.00 KiB @ 1.77 MiB/s (eta 0s )
  Programming ✔ [00:00:00] [############################################################################] 49.16 KiB/49.16 KiB @ 51.73 KiB/s (eta 0s )    Finished in 1.075s

running 4 tests
test tests::test_aes_128_encryption ... ok
test tests::test_aes_128_decryption ... ok
test tests::test_aes_256_encryption ... ok
test tests::test_aes_256_decryption ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.47s

Manually triggered the HIL workflow: https://github.com/esp-rs/esp-hal/actions/runs/8646947366

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue Apr 11, 2024
Merged via the queue into esp-rs:main with commit da3375b Apr 11, 2024
21 checks passed
@SergioGasquez SergioGasquez deleted the feat/hil-aes branch April 12, 2024 06:36
SergioGasquez added a commit to SergioGasquez/esp-hal that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants