Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/3] DMA Move API: Move DMA descriptors to peripheral drivers #1719

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Dominaezzz
Copy link
Collaborator

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This is part of #1512 .

This is breaking change to move the DMA descriptors from the DMA channel to the individual DMA capable peripheral drivers.
Besides the actual descriptor move, there's another change which is to mandate that the descriptors are now 'static.
I tried not to mandate this but the borrow checker was fussing so I did it to save some hair.
This was going to be required eventually for soundness anyway and the impact to users will be negligible since most of them will be using the dma_buffer macros, which will do the right thing. So this I think this is fine.

Testing

HIL in CI

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking quite good, thanks for your continued work on this.

We are unfortunately having some issues with our HIL setup currently and are blocked on merging, but I will merge this as soon as I'm able.

@jessebraham jessebraham added this pull request to the merge queue Jun 26, 2024
Merged via the queue into esp-rs:main with commit 7753551 Jun 26, 2024
29 checks passed
@Dominaezzz Dominaezzz deleted the dma_descr branch June 26, 2024 21:21
@bugadani bugadani mentioned this pull request Oct 3, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants