[2/3] DMA Move API: Move DMA descriptors to peripheral drivers #1719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This is part of #1512 .
This is breaking change to move the DMA descriptors from the DMA channel to the individual DMA capable peripheral drivers.
Besides the actual descriptor move, there's another change which is to mandate that the descriptors are now
'static
.I tried not to mandate this but the borrow checker was fussing so I did it to save some hair.
This was going to be required eventually for soundness anyway and the impact to users will be negligible since most of them will be using the
dma_buffer
macros, which will do the right thing. So this I think this is fine.Testing
HIL in CI