Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new constructor to gpio::Io which does not bind an interrupt handler #1861

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

jessebraham
Copy link
Member

Wasn't sure what to call it (as usual), but I think this is a reasonable enough name. Happy to change it if anybody has any better suggestions.

I think the comment should hopefully suffice, but again let me know if I should make it more scary and/or mention anything else.

Closes #1858

@jessebraham jessebraham requested a review from bjoernQ July 26, 2024 13:00
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev enabled auto-merge July 26, 2024 13:13
@MabezDev MabezDev added this pull request to the merge queue Jul 26, 2024
Merged via the queue into esp-rs:main with commit 237804e Jul 26, 2024
18 checks passed
@jessebraham jessebraham deleted the feature/no-io-handler branch July 27, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide some way to *not* bind an interrupt handler in Io::new
3 participants