Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update probe-rs version #1914

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Aug 9, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Update probe-rs version to current main (bba1bb5). There are a few PRs related to ESP32s, but since I'll be away for the next weeks, I'd rather test the new probe-rs version a few days while Im still around.

With the new probe-rs version, the noisy RTT errors are no longer present and we dont need the --chip argument.

Testing

HIL workflow runs:

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Aug 9, 2024
Merged via the queue into esp-rs:main with commit 2e8937a Aug 9, 2024
18 checks passed
@SergioGasquez SergioGasquez deleted the feat/update-probers branch August 9, 2024 15:10
@bugadani
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants