Add DMA buffer view support to I8080 driver #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Oct 4, 2024
bugadani
approved these changes
Oct 7, 2024
bugadani
pushed a commit
to bugadani/esp-hal
that referenced
this pull request
Oct 7, 2024
* Add DMA buffer view support to I8080 driver * reconstruct buffer before dropping --------- Co-authored-by: Dominic Fischer <git@dominicfischer.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Add the ability to safely view the DMA buffer whilst it's in use. Similar to what was done for #2242 .
There aren't any
DmaTxBuffer' implementations that have meaningful views right now but in the near future I'll be introducing aDmaTxStreamBuf(and maybe aDmaTxCircularBufif I figure what to do with #2021).No changelog because this is more/less an extension of #2191 which hasn't been released yet.
Testing
At the moment there aren't any
DmaTxBuffer' implementations that support views so I can't "test" this but the code changes should be pretty straight forward.