Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erase TWAI #2359

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Erase TWAI #2359

merged 6 commits into from
Oct 24, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 16, 2024 •
edited
Loading

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

@bugadani bugadani mentioned this pull request Oct 16, 2024
Closed
@bugadani bugadani force-pushed the erase-twai branch 4 times, most recently from a1d743c to 8a1d02b Compare October 21, 2024 14:42
@bugadani bugadani mentioned this pull request Oct 21, 2024
Merged
@bugadani bugadani force-pushed the erase-twai branch 4 times, most recently from 8e9a1a2 to 7f5d90e Compare October 22, 2024 08:01
@bugadani bugadani marked this pull request as ready for review October 22, 2024 08:03
MabezDev
MabezDev reviewed Oct 22, 2024
View reviewed changes
esp-hal/MIGRATING-0.21.md Outdated Show resolved Hide resolved
@bugadani bugadani force-pushed the erase-twai branch 3 times, most recently from 11e238d to 5986dc6 Compare October 23, 2024 08:41
@MabezDev MabezDev marked this pull request as draft October 23, 2024 10:05
@bugadani bugadani marked this pull request as ready for review October 23, 2024 13:46
MabezDev
MabezDev requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a function, but after that LGTM

esp-hal/src/twai/mod.rs Show resolved Hide resolved
bjoernQ
bjoernQ approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bugadani bugadani added this pull request to the merge queue Oct 24, 2024
Merged via the queue into esp-rs:main with commit c163b05 Oct 24, 2024
28 checks passed
@bugadani bugadani deleted the erase-twai branch October 24, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @bjoernQ @MabezDev