Remove FullDuplexMode and HalfDuplexMode type params #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
spi-duplex
branch
4 times, most recently
from
9f9b636
to
7123905
Compare
bugadani
force-pushed
the
spi-duplex
branch
3 times, most recently
from
beff65e
to
ce59e71
Compare
MabezDev
reviewed
Oct 21, 2024
Dominaezzz
reviewed
Oct 21, 2024
bugadani
force-pushed
the
spi-duplex
branch
2 times, most recently
from
9f87fd1
to
0aead7d
Compare
bjoernQ
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
The biggest change is the ability to use HD and FD devices on the same bus at the same time. The changes got a bit involved, though.