Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-generate pacakge installation #80

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

SergioGasquez
Copy link
Member

Closes #78

We are currently using x86_64-unknown-linux-musl for x86_64-unknown-linux-gnu arch. If cargo-generate/cargo-generate/pull/602 gets merged I will update the script

@SergioGasquez SergioGasquez self-assigned this May 26, 2022
Copy link
Collaborator

@georgik georgik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 413 GENERATE_VERSION is executed always even in case when nothing is requested to install. It adds a dependency on git. Isn't there a simpler way without involving git and bunch of other tools to get latest version? Even fixed version might be better approach.

@SergioGasquez
Copy link
Member Author

Line 413 GENERATE_VERSION is executed always even in case when nothing is requested to install. It adds a dependency on git. Isn't there a simpler way without involving git and bunch of other tools to get latest version? Even fixed version might be better approach.

I encapsulated the git command in an if statement that is only executed when installing cargo-generate, to avoid potential errors from the git command when not installing cargo-generate as we discussed.

I also update the arch being used because they merged cargo-generate/cargo-generate/pull/602 and generated a new release which now has binary packages for x86_64-unknown-linux-gnu.

Finally, I updated the ESP_IDF_VERSION checks to use -z and -n

@SergioGasquez SergioGasquez linked an issue Jun 3, 2022 that may be closed by this pull request
@georgik
Copy link
Collaborator

georgik commented Jun 8, 2022

@SergioGasquez The change looks good. Please could you resolve also the conflict so that we can merge the feature?

@SergioGasquez
Copy link
Member Author

@SergioGasquez The change looks good. Please could you resolve also the conflict so that we can merge the feature?

Conflicts resolved!

@SergioGasquez SergioGasquez merged commit c43fbb3 into main Jun 8, 2022
@SergioGasquez SergioGasquez deleted the feature/cargo-generate-pacakge branch June 8, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants