Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix asm! build error for Rust1.59.0.0 #44

Merged
merged 1 commit into from
Feb 24, 2022
Merged

build: fix asm! build error for Rust1.59.0.0 #44

merged 1 commit into from
Feb 24, 2022

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented Feb 24, 2022 •
edited
Loading

@georgik
Copy link
Collaborator

georgik commented Feb 24, 2022

Would it work in 1.60?

@bjoernQ
Copy link

bjoernQ commented Feb 24, 2022

Should work with 1.60 - the version matching is a bit confusing: https://doc.rust-lang.org/beta/unstable-book/language-features/cfg-version.html

However, it's nightly only - not a problem for Xtensa since the toolchain is always dev but for RISCV I guess it won't compile on stable

MabezDev
MabezDev approved these changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

That version cfg is super confusing, hopefully they change that before its stabilized 😅

@MabezDev MabezDev merged commit bab7163 into espressif:main Feb 24, 2022
@georgik
Copy link
Collaborator

georgik commented Feb 25, 2022

@JurajSadel Thank you for finding the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JurajSadel @georgik @bjoernQ @MabezDev