Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid defining names which easily clash #21

Closed
carymrobbins opened this issue Apr 18, 2018 · 1 comment
Closed

Avoid defining names which easily clash #21

carymrobbins opened this issue Apr 18, 2018 · 1 comment

Comments

@carymrobbins
Copy link
Member

This doesn't compile due to the use of T as a type param in the generated deriving method -

@newtype case class CanDerive[F[_], R, T](value: F[T])

Generates this method -

def deriving[T[_], F[_], R, T](implicit ev: T[Repr[F, R, T]]): T[Type[F, R, T]] = ev.asInstanceOf[T[Type[F, R, T]]]

We should go through the methods and make sure we use unique names, either by suffixing with $ or using something like c.freshName.
carymrobbins added a commit that referenced this issue Apr 19, 2018
@carymrobbins
refs #21: Avoid defining clashing type params in deriving methods
7a41ebd
@carymrobbins carymrobbins mentioned this issue Apr 19, 2018
Merged
carymrobbins added a commit that referenced this issue Apr 20, 2018
@carymrobbins
refs #21: Avoid defining clashing type params in deriving methods
cbd58a0
@carymrobbins
Copy link
Member Author

This will be fixed in the v0.4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carymrobbins