Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick of #11694 on release-3.4 #11696

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

hexfusion
Copy link
Contributor

Cherry pick of #11694 on release-3.4.

#11694: proxy/grpcproxy: add return on error for metrics handler

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Contributor Author

CI failure is unrelated

#11664 (review)

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @hexfusion

@hexfusion hexfusion merged commit b66c53f into etcd-io:release-3.4 Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants