Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use 'io.Seek*' for go1.7+ #7545

Merged
merged 1 commit into from
Mar 20, 2017
Merged

*: use 'io.Seek*' for go1.7+ #7545

merged 1 commit into from
Mar 20, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Mar 20, 2017

For #6174.

@xiang90
Copy link
Contributor

xiang90 commented Mar 20, 2017

LGTM

@gyuho
Copy link
Contributor Author

gyuho commented Mar 20, 2017

@heyitsanthony This breaks in jenkins. When do we switch to go 1.8 in jenkins?
We can just wait until then.

@gyuho gyuho added the WIP label Mar 20, 2017
@gyuho gyuho modified the milestones: v3.2.0-maybe, v3.2.0 Mar 20, 2017
For etcd-io#6174.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho gyuho changed the title *: use 'time.Until', 'io.Seek*' for go1.7 and 1.8 *: use 'io.Seek*' for go1.7+ Mar 20, 2017
@gyuho gyuho removed the WIP label Mar 20, 2017
@gyuho
Copy link
Contributor Author

gyuho commented Mar 20, 2017

Nuked the time.Until change and keeping go1.8 notes in README for later changes.

@gyuho gyuho merged commit 27550b2 into etcd-io:master Mar 20, 2017
@gyuho gyuho deleted the go1.7-go1.8 branch March 20, 2017 23:31
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@3a1368d). Click here to learn what that means.
The diff coverage is 44.44%.

@@            Coverage Diff            @@
##             master    #7545   +/-   ##
=========================================
  Coverage          ?   70.27%           
=========================================
  Files             ?      320           
  Lines             ?    26214           
  Branches          ?        0           
=========================================
  Hits              ?    18422           
  Misses            ?     6343           
  Partials          ?     1449
Impacted Files Coverage Δ
pkg/fileutil/lock_linux.go 76.66% <ø> (ø)
pkg/fileutil/preallocate.go 25% <0%> (ø)
wal/repair.go 48% <0%> (ø)
pkg/fileutil/fileutil.go 69.56% <100%> (ø)
wal/encoder.go 84.31% <100%> (ø)
etcdctl/ctlv3/command/snapshot_command.go 64.77% <25%> (ø)
wal/wal.go 61.81% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1368d...aca2abd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants