Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed: remove ReadTimeout TODO #7736

Merged
merged 1 commit into from
Apr 13, 2017
Merged

embed: remove ReadTimeout TODO #7736

merged 1 commit into from
Apr 13, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Apr 13, 2017

@gyuho
embed: remove ReadTimeout TODO
537c710 
ref. golang/go#9524 (comment)

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho gyuho requested a review from heyitsanthony April 13, 2017 17:56
@heyitsanthony
Copy link
Contributor

oh should this use closeNotify, then?

@gyuho gyuho added WIP and removed WIP labels Apr 13, 2017
@gyuho gyuho merged commit 9eb3e2c into etcd-io:master Apr 13, 2017
@gyuho gyuho deleted the todo branch April 13, 2017 18:40
@gyuho
Copy link
Contributor Author

gyuho commented Apr 13, 2017

I will keep track of CloseNotify feature here #6174, since it works with Go 1.8+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyitsanthony heyitsanthony heyitsanthony approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @heyitsanthony