Render link hook shouldn't rewrite paths

[chalin]

The render-link hook is currently rewriting URL paths for non-external links using the .GetPage feature (see line 8 below):

website/layouts/_default/_markup/render-link.html

Lines 1 to 16 in 6fdc098

	{{ $link := .Destination -}}
	{{ $isRemote := strings.HasPrefix $link "http" -}}
	{{ if not $isRemote -}}
	{{ $url := urls.Parse .Destination -}}
	{{ if $url.Path -}}
	{{ $fragment := "" -}}
	{{ with $url.Fragment }}{{ $fragment = printf "#%s" . }}{{ end -}}
	{{ with .Page.GetPage $url.Path }}{{ $link = printf "%s%s" .RelPermalink $fragment }}{{ end -}}
	{{ end -}}
	{{ end -}}
	<a href="{{ $link | safeURL }}"
	{{- with .Title}} title="{{ . }}"{{ end -}}
	{{- if $isRemote }} target="_blank" rel="noopener"{{ end -}}
	>
	{{- .Text | safeHTML -}}
	</a>

IMHO, the render-link hook is useful for changing the appearance of links (e.g., see #269), but it shouldn't rewrite URLs. The relref internal Hugo function should be used instead if/when we want to rewrite paths based on page lookups.

This might be a vestige of the time when the docs were a part of the etcd repo rather than here under the website repo.