fix links in 3.3 #448
Merged
fix links in 3.3 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
approved these changes
Aug 17, 2021
|
Thanks for working on these @kapunahelewong! |
7 tasks
chalin
reviewed
Aug 17, 2021
| @@ -6,7 +6,7 @@ title: Clustering Guide | |||
|
|
|||
| Starting an etcd cluster statically requires that each member knows another in the cluster. In a number of cases, the IPs of the cluster members may be unknown ahead of time. In these cases, the etcd cluster can be bootstrapped with the help of a discovery service. | |||
|
|
|||
| Once an etcd cluster is up and running, adding or removing members is done via [runtime reconfiguration][runtime-conf]. To better understand the design behind runtime reconfiguration, we suggest reading [the runtime configuration design document][runtime-reconf-design]. | |||
| Once an etcd cluster is up and running, adding or removing members is done via [runtime reconfiguration][runtime-conf]. To better understand the design behind runtime reconfiguration, we suggest reading [the runtime configuration design document][../../runtime-reconf-design]. | |||
There was a problem hiding this comment.
Oops, missed this the first time around: this link shouldn't have been changed. The link definition is fixed below in line 495.
So just revert the change to this line.
chalin
requested changes
Aug 17, 2021
| @@ -6,7 +6,7 @@ etcd comes with support for incremental runtime reconfiguration, which allows us | |||
|
|
|||
| Reconfiguration requests can only be processed when a majority of cluster members are functioning. It is **highly recommended** to always have a cluster size greater than two in production. It is unsafe to remove a member from a two member cluster. The majority of a two member cluster is also two. If there is a failure during the removal process, the cluster might not be able to make progress and need to [restart from majority failure][majority failure]. | |||
|
|
|||
| To better understand the design behind runtime reconfiguration, please read [the runtime reconfiguration document][runtime-reconf]. | |||
| To better understand the design behind runtime reconfiguration, please read [the runtime reconfiguration document][../../runtime-reconf]. | |||
There was a problem hiding this comment.
Ditto, missed this the first time around: this link shouldn't have been changed. Revert the change to this line, and change the definition of [runtime-reconf] on line 175 below.
|
FYI, I used this diff command over the generated site to find the broken links: $ git diff -I '^<meta \w+="[^"]*(date|time)' -I '>Last modified' -- . ':(exclude)*.xml' > ~/tmp/diff.txt
$ grep -e ^diff ~/tmp/diff.txt
diff --git a/docs/v3.3/branch_management/index.html b/docs/v3.3/branch_management/index.html
diff --git a/docs/v3.3/install/index.html b/docs/v3.3/install/index.html
diff --git a/docs/v3.3/op-guide/clustering/index.html b/docs/v3.3/op-guide/clustering/index.html
diff --git a/docs/v3.3/op-guide/runtime-configuration/index.html b/docs/v3.3/op-guide/runtime-configuration/index.html
diff --git a/docs/v3.3/platforms/aws/index.html b/docs/v3.3/platforms/aws/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken links in v3.3 as per #419