Added blog for the content of etcd/contrib/lock/README.md #453
Conversation
There was a problem hiding this comment.
Hi @unnati914, thank you for this article!
I've added @chalin and @ptabor as reviewers as I believe they were the original authors of the code and page that this article is replacing.
Some notes about the structure of this article:
- Since the original file was written as a README in a primarily code based repo, there is an expectation that the accompanying files would be there (and you reference this when you write "The directory contains two programs"), so we'll need to figure out a way to restructure this article in a way that will allow the reader to find those files and refer to them.
- This restructure may be having that code be a part of the body of the article, or perhaps the original folder should be included and linked to here. Another option may be to zip the files and provide it as a package that the reader can download.
- The images in the original write up were useful, and appear to be a part of this PR, but don't appear in the rendered page (see the deploy preview), or linked to in the text (though references to figures are made).
I'd suggest generally keeping closer to the formatting and style of the original page (and include a reference for attribution), and adding an introduction explaining what this article is for and how to use the executables I've suggested including above.
| - $ ./build # build etcd | ||
| $ goreman start |
There was a problem hiding this comment.
I'd suggest using a code fence rather than a bullet for code/terminal samples like this.
$ ./build # build etcd
$ goreman start
(a code fence is surrounding a bit of code with "```" on the lines above and below it)
|
sure I will be doing the changes |
|
Closing as this hasn't been updated. Feel free to reopen if you want to continue working on this article. |
Fixes #200
Note: I haven't added the title to the blog, will add it once you review it.