Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add URLs to ignore and fix broken links for v3.5 #462

Merged
merged 2 commits into from
Apr 20, 2023
Merged

add URLs to ignore and fix broken links for v3.5 #462

merged 2 commits into from
Apr 20, 2023

Conversation

kapunahelewong
Copy link
Contributor

Adds URLs to ignore to .htmltest.yml and fix broken links.

Though this has been added:

"^https://learn.hashicorp.com/tutorials/consul/add-remove-servers?in=consul/day-2-operations"

npm run check-links:all still fails. Any suggestions anyone?

@kapunahelewong kapunahelewong mentioned this pull request Aug 25, 2021
Closed
nate-double-u
nate-double-u reviewed Aug 25, 2021
View reviewed changes
.htmltest.yml Outdated Show resolved Hide resolved
@jberkus
Copy link
Contributor

jberkus commented Apr 20, 2023

Seems still relevant, I'll resolve the conflicts, and port it to 3.5 as well.

@jberkus jberkus merged commit 231ef85 into etcd-io:main Apr 20, 2023
@naiba4 naiba4 mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u left review comments

@debeer064 debeer064 debeer064 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kapunahelewong @jberkus @nate-double-u @debeer064