SKIP TestUPNP_DDWRT test if device is (IGDv2-IP1) non dd-wrt

etclabscore · Oct 22, 2020 · 00e9a56 · 00e9a56
1 parent 0d28b80
commit 00e9a56
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/p2p/nat/natupnp_test.go b/p2p/nat/natupnp_test.go
@@ -164,14 +164,18 @@ func TestUPNP_DDWRT(t *testing.T) {
 	if discovered == nil {
 		t.Fatalf("not discovered")
 	}
+
 	upnp, _ := discovered.(*upnp)
-	if upnp.service != "IGDv1-IP1" {
+	if upnp.service == "IGDv1-IP1" {
+		wantURL := "http://" + dev.listener.Addr().String() + "/InternetGatewayDevice.xml"
+		if upnp.dev.URLBaseStr != wantURL {
+			t.Errorf("upnp.dev.URLBaseStr mismatch: got %q, want %q", upnp.dev.URLBaseStr, wantURL)
+		}
+	} else if upnp.service == "IGDv2-IP1" {
+		t.Skipf("disabled: non dd-wrt IGDv2-IP1 detected")
+	} else {
 		t.Errorf("upnp.service mismatch: got %q, want %q", upnp.service, "IGDv1-IP1")
 	}
-	wantURL := "http://" + dev.listener.Addr().String() + "/InternetGatewayDevice.xml"
-	if upnp.dev.URLBaseStr != wantURL {
-		t.Errorf("upnp.dev.URLBaseStr mismatch: got %q, want %q", upnp.dev.URLBaseStr, wantURL)
-	}
 }
 
 // fakeIGD presents itself as a discoverable UPnP device which sends