Convert YoloV2 flags to EIP-2315 and EIP-2929 #246
Conversation
…sed for `EIP2537FBlock`
…nt checks to the corresponding EIPs
…parity_configurator.go
not yet pulled from upstream to multigeth
params/config.go
Outdated
| @@ -30,8 +30,7 @@ var ( | |||
| RopstenGenesisHash = common.HexToHash("0x41941023680923e0fe4d74a34bdac8141f2540e3ae90623718e47d66d1ca4a2d") | |||
| RinkebyGenesisHash = common.HexToHash("0x6341fd3daf94b748c72ced5a5b26028f2474f5f00d824504e4fa37a75767e177") | |||
| GoerliGenesisHash = common.HexToHash("0xbf7e331f7f7c1dd2e05159666b3bf8bc7a8a3a9eb1d518969eab529dd9b88c1a") | |||
| // TODO: update with yolov2 values | |||
| YoloV2GenesisHash = common.HexToHash("0x498a7239036dd2cd09e2bb8a80922b78632017958c332b42044c250d603a8a3e") | |||
| YoloV2GenesisHash = common.HexToHash("0xc3fd235071f24f93865b0850bd2a2119b30f7224d18a0e34c7bbf549ad7e3d36") // TODO: check if yolov2 is correct | |||
There was a problem hiding this comment.
At go-ethereum they left this on yolov1 until they get the new value. Though we have a testcase that fails. So I temporarily used the output of the test to make it happy
There was a problem hiding this comment.
Not really, we just chose to use the exact same genesis (alloc + time but not chainId) for yolov2 as yolov1.
There was a problem hiding this comment.
Thanks @holiman for jumping in, this clears up everything. I will fix anything needed to make the test pass then.
| EIP2537Transition *ParityU64 `json:"eip2537Transition,omitempty"` | ||
| EIP1706Transition *ParityU64 `json:"-"` // FIXME, when and if i'm implemented in Parity | ||
| EIP2929Transition *ParityU64 `json:"-"` // FIXME, when and if i'm implemented in Parity |
There was a problem hiding this comment.
We have a test case on forks (TestEquivalent_Features) that fails on this transition. The thing is that OpenEthereum is not going to implement this EIP as they are out of resources at this moment.
What is the best way to handle this test case @meowsbits?
There was a problem hiding this comment.
I'm guessing func (spec *ParityChainSpec) SetEIP2929Transition(n *uint64) error { needs to actually set EIP2929Transition, in the same way as EIP2315 is handled for Parity.
There was a problem hiding this comment.
This resolves our test but I though of leaving it unsupported based on the comment here saying that they are not going to implement this.
There was a problem hiding this comment.
Ah, roger that. I've reverted that commit and just modified the tests to skip Parity :: [Berlin|YOLO] tests. See 186e3cb and subsequent.
Fixes ./integration/#TestEquivalent_Features Resolves https://github.com/etclabscore/core-geth/pull/246/files#r535740801 Date: 2020-12-04 06:52:01-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…g EIPs" This reverts commit 75af684.
This reverts commit f3aff0e.
…forks EIP2929 is and will be unsupported by Parity, so we cannot test chain config feature equivalence for forks that demand that feature. Skip those tests. Date: 2020-12-04 07:45:40-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2020-12-04 07:57:11-06:00 Signed-off-by: meows <b5c6@protonmail.com>
No description provided.