Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: null is not an object (evaluating 'browserSheet.insertRule') #4961

Closed
rhansen opened this issue Mar 19, 2021 · 1 comment · Fixed by #4963
Closed

TypeError: null is not an object (evaluating 'browserSheet.insertRule') #4961

rhansen opened this issue Mar 19, 2021 · 1 comment · Fixed by #4963

Comments

@rhansen
Copy link
Member

rhansen commented Mar 19, 2021 •
edited
Loading

Client-side exception at src/static/js/cssmanager.js#L64 on latest develop (cb9f6d6). Seems to only happen on Safari. It doesn't always happen, so it appears to be a race condition. I had hoped that PR #4960 would fix it, but it did not.
@webzwo0i
Copy link
Member

Do you have a trace to find out which makeCSSManager call caused it?

@rhansen rhansen mentioned this issue Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cssmanager: Refactor CSS manager creation to avoid race condition ether/etherpad-lite
2 participants
@rhansen @webzwo0i