Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page initialization #371

Merged
merged 9 commits into from
Jan 30, 2012
Merged

Page initialization #371

merged 9 commits into from
Jan 30, 2012

Commits on Jan 28, 2012

  1. Expose settings on pad object.

    @cweider
    cweider committed Jan 28, 2012
    Configuration menu
    Copy the full SHA
    56c07e4 View commit details
    Browse the repository at this point in the history

  2. Inject pad dependencies into most pad submodules.

    @cweider
    cweider committed Jan 28, 2012
    Configuration menu
    Copy the full SHA
    5146981 View commit details
    Browse the repository at this point in the history

  3. Give controller for pad.html a more appropriate name.

    @cweider
    cweider committed Jan 28, 2012
    Configuration menu
    Copy the full SHA
    3e9b56a View commit details
    Browse the repository at this point in the history

  4. Shift pad initialization into JavaScript.

    @cweider
    cweider committed Jan 28, 2012
    Configuration menu
    Copy the full SHA
    cd86ef5 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2012

  1. Remove all global dependencies from broadcast modules.

    @cweider
    cweider committed Jan 29, 2012
    Configuration menu
    Copy the full SHA
    d934fd6 View commit details
    Browse the repository at this point in the history

  2. Move timeslider code into JS.

    @cweider
    cweider committed Jan 29, 2012
    Configuration menu
    Copy the full SHA
    67e6f9f View commit details
    Browse the repository at this point in the history

  3. Place script at bottom.

    @cweider
    cweider committed Jan 29, 2012
    Configuration menu
    Copy the full SHA
    c12e1af View commit details
    Browse the repository at this point in the history

  4. Global exception handler is not registered until the page's controlle… 

    …r adds it.

It is bad form to register this handler on definition. This would cause problems if, for instance, this module was required by our Node code.
    @cweider
    cweider committed Jan 29, 2012
    Configuration menu
    Copy the full SHA
    6a4c025 View commit details
    Browse the repository at this point in the history

  5. Make implicit loading of modules unnecessary. 

    This is one step on the way to simplifying `Minify` and allowing all of the modules within pad.js to be loaded independently in development mode (which is useful for debugging).
    @cweider
    cweider committed Jan 29, 2012
    Configuration menu
    Copy the full SHA
    a408557 View commit details
    Browse the repository at this point in the history